Use only EventNotFound for a better backwards compatibility

Author: pjurewicz

ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb

@@ -140,7 +140,7 @@ def start_condition(specification)
           @stream_klass.table_name
         )
       rescue ::ActiveRecord::RecordNotFound
-        raise EventNotFoundInStream
+        raise EventNotFound.new(specification.start)
       end
 
       def stop_condition(specification)
@@ -150,7 +150,7 @@ def stop_condition(specification)
           @stream_klass.table_name
         )
       rescue ::ActiveRecord::RecordNotFound
-        raise EventNotFoundInStream
+        raise EventNotFound.new(specification.stop)
       end
 
       def start_condition_in_global_stream(specification)

ruby_event_store/lib/ruby_event_store/in_memory_repository.rb

@@ -150,12 +150,8 @@ def read_scope(spec)
       serialized_records = serialized_records.select { |e| spec.with_types.any? { |x| x.eql?(e.event_type) } } if spec
         .with_types?
       serialized_records = serialized_records.reverse if spec.backward?
-      begin
-        serialized_records = serialized_records.drop(index_of(serialized_records, spec.start) + 1) if spec.start
-        serialized_records = serialized_records.take(index_of(serialized_records, spec.stop)) if spec.stop
-      rescue EventNotFound => e
-        raise spec.stream.global? ? e : EventNotFoundInStream
-      end
+      serialized_records = serialized_records.drop(index_of(serialized_records, spec.start) + 1) if spec.start
+      serialized_records = serialized_records.take(index_of(serialized_records, spec.stop)) if spec.stop
       serialized_records = serialized_records.take(spec.limit) if spec.limit?
       serialized_records = serialized_records.select { |sr| Time.iso8601(time_comparison_field(spec, sr)) < spec.older_than } if spec
         .older_than

ruby_event_store/lib/ruby_event_store/spec/event_repository_lint.rb

@@ -1060,15 +1060,15 @@ def read_events_backward(repository, stream = nil, from: nil, to: nil, count: ni
       repository.append_to_stream([event], Stream.new('dummy'), ExpectedVersion.any)
       expect do
         repository.read(specification.stream('another').from(event.event_id).result).to_a
-      end.to raise_error(RubyEventStore::EventNotFoundInStream)
+      end.to raise_error(RubyEventStore::EventNotFound, "Event not found: #{event.event_id}")
     end
 
     specify do
       event = SRecord.new
       repository.append_to_stream([event], Stream.new('dummy'), ExpectedVersion.any)
       expect do
         repository.read(specification.stream('another').to(event.event_id).result).to_a
-      end.to raise_error(RubyEventStore::EventNotFoundInStream)
+      end.to raise_error(RubyEventStore::EventNotFound, "Event not found: #{event.event_id}")
     end
 
     specify do

ruby_event_store/spec/client_spec.rb

@@ -398,10 +398,10 @@ module RubyEventStore
       end
 
       expect { client.read.stream("stream_name").from(SecureRandom.uuid).limit(100).to_a }.to raise_error(
-        EventNotFoundInStream
+        EventNotFound
       )
       expect { client.read.backward.stream("stream_name").from(SecureRandom.uuid).limit(100).to_a }.to raise_error(
-        EventNotFoundInStream
+        EventNotFound
       )
     end