Reduce complexity via template_directory method

Template directory depends on used adapter type, so it's a viable place
to keep this information close to the adapter itself. Yet another case
statement removed.

Author: fidel

ruby_event_store-active_record/lib/ruby_event_store/active_record.rb

@@ -3,7 +3,6 @@
 require_relative "active_record/generators/database_adapter"
 require_relative "active_record/generators/migration_generator"
 require_relative "active_record/generators/rails_migration_generator"
-require_relative "active_record/generators/templates/template_directory"
 require_relative "active_record/generators/event_id_index_migration_generator"
 require_relative "active_record/generators/rails_event_id_index_migration_generator"
 require_relative "active_record/generators/foreign_key_on_event_id_migration_generator"

ruby_event_store-active_record/lib/ruby_event_store/active_record/generators/database_adapter.rb

@@ -14,6 +14,10 @@ class PostgreSQL < self
         def initialize(data_type = NOT_SET)
           super("postgresql", data_type)
         end
+
+        def template_directory
+          "postgres/"
+        end
       end
 
       class MySQL < self
@@ -22,6 +26,10 @@ class MySQL < self
         def initialize(data_type = NOT_SET)
           super("mysql2", data_type)
         end
+
+        def template_directory
+          "mysql/"
+        end
       end
 
       class SQLite < self
@@ -57,6 +65,9 @@ def hash
         DatabaseAdapter.hash ^ adapter_name.hash
       end
 
+      def template_directory
+      end
+
       def self.from_string(adapter_name, data_type = NOT_SET)
         raise NoMethodError unless eql?(DatabaseAdapter)
 

ruby_event_store-active_record/lib/ruby_event_store/active_record/generators/foreign_key_on_event_id_migration_generator.rb

@@ -38,11 +38,7 @@ def migration_template(template_root, name)
       end
 
       def template_root(database_adapter)
-        absolute_path("./templates/#{template_directory(database_adapter)}")
-      end
-
-      def template_directory(database_adapter)
-        TemplateDirectory.for_adapter(database_adapter)
+        absolute_path("./templates/#{database_adapter.template_directory}")
       end
 
       def migration_version

ruby_event_store-active_record/lib/ruby_event_store/active_record/generators/migration_generator.rb

@@ -22,11 +22,7 @@ def migration_code(database_adapter)
       end
 
       def template_root(database_adapter)
-        absolute_path("./templates/#{template_directory(database_adapter)}")
-      end
-
-      def template_directory(database_adapter)
-        TemplateDirectory.for_adapter(database_adapter)
+        absolute_path("./templates/#{database_adapter.template_directory}")
       end
 
       def migration_template(template_root, name)

ruby_event_store-active_record/lib/ruby_event_store/active_record/generators/rails_foreign_key_on_event_id_migration_generator.rb

@@ -27,12 +27,12 @@ def initialize(*args)
         def create_migration
           case @database_adapter
           when DatabaseAdapter::PostgreSQL
-            template "#{template_directory}add_foreign_key_on_event_id_to_event_store_events_in_streams_template.erb",
+            template "#{@database_adapter.template_directory}add_foreign_key_on_event_id_to_event_store_events_in_streams_template.erb",
                      "db/migrate/#{timestamp}_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb"
-            template "#{template_directory}validate_add_foreign_key_on_event_id_to_event_store_events_in_streams_template.erb",
+            template "#{@database_adapter.template_directory}validate_add_foreign_key_on_event_id_to_event_store_events_in_streams_template.erb",
                      "db/migrate/#{timestamp}_validate_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb"
           else
-            template "#{template_directory}add_foreign_key_on_event_id_to_event_store_events_in_streams_template.erb",
+            template "#{@database_adapter.template_directory}add_foreign_key_on_event_id_to_event_store_events_in_streams_template.erb",
                      "db/migrate/#{timestamp}_add_foreign_key_on_event_id_to_event_store_events_in_streams.rb"
           end
         end
@@ -50,10 +50,6 @@ def migration_version
         def timestamp
           Time.now.strftime("%Y%m%d%H%M%S")
         end
-
-        def template_directory
-          TemplateDirectory.for_adapter(@database_adapter)
-        end
       end
     end
   end

ruby_event_store-active_record/lib/ruby_event_store/active_record/generators/rails_migration_generator.rb

@@ -34,16 +34,12 @@ def initialize(*args)
       end
 
       def create_migration
-        template "#{template_directory}create_event_store_events_template.erb",
+        template "#{@database_adapter.template_directory}create_event_store_events_template.erb",
                  "db/migrate/#{timestamp}_create_event_store_events.rb"
       end
 
       private
 
-      def template_directory
-        TemplateDirectory.for_adapter(@database_adapter)
-      end
-
       def data_type
         options.fetch("data_type")
       end

ruby_event_store-active_record/lib/ruby_event_store/active_record/generators/templates/template_directory.rb

@@ -55,6 +55,12 @@ module ActiveRecord
         expect { DatabaseAdapter.new("postgresql", "jsonb") }.to raise_error(UnsupportedAdapter)
       end
 
+      specify "template directory" do
+        expect(DatabaseAdapter::PostgreSQL.new.template_directory).to eq("postgres/")
+        expect(DatabaseAdapter::MySQL.new.template_directory).to eq("mysql/")
+        expect(DatabaseAdapter::SQLite.new.template_directory).to be_nil
+      end
+
       context "data type verification" do
         specify "MySQL supports binary" do
           expect(DatabaseAdapter::MySQL.new("binary").data_type).to eq("binary")