test: P2SH sig ops are only counted with SCRIPT_VERIFY_P2SH flag

brunoerg · Raimo33 · commit 15fea9ffecbd · 2025-10-17T20:23:36.000+02:00
diff --git a/src/test/sigopcount_tests.cpp b/src/test/sigopcount_tests.cpp
@@ -151,6 +151,9 @@ BOOST_AUTO_TEST_CASE(GetTxSigOpCost)
         BuildTxs(spendingTx, coins, creationTx, scriptPubKey, scriptSig, CScriptWitness());
         assert(GetTransactionSigOpCost(CTransaction(spendingTx), coins, flags) == 2 * WITNESS_SCALE_FACTOR);
         assert(VerifyWithFlag(CTransaction(creationTx), spendingTx, flags) == SCRIPT_ERR_CHECKMULTISIGVERIFY);
+
+        // P2SH sigops are not counted if we don't set the SCRIPT_VERIFY_P2SH flag
+        assert(GetTransactionSigOpCost(CTransaction(spendingTx), coins, /*flags=*/0) == 0);
     }
 
     // P2WPKH witness program

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,9 @@ BOOST_AUTO_TEST_CASE(GetTxSigOpCost)`
`151`	`151`	`BuildTxs(spendingTx, coins, creationTx, scriptPubKey, scriptSig, CScriptWitness());`
`152`	`152`	`assert(GetTransactionSigOpCost(CTransaction(spendingTx), coins, flags) == 2 * WITNESS_SCALE_FACTOR);`
`153`	`153`	`assert(VerifyWithFlag(CTransaction(creationTx), spendingTx, flags) == SCRIPT_ERR_CHECKMULTISIGVERIFY);`
	`154`	`+`
	`155`	`+ // P2SH sigops are not counted if we don't set the SCRIPT_VERIFY_P2SH flag`
	`156`	`+ assert(GetTransactionSigOpCost(CTransaction(spendingTx), coins, /flags=/0) == 0);`
`154`	`157`	`}`
`155`	`158`
`156`	`159`	`// P2WPKH witness program`