Skip to content

Commit 0bb0e45

Browse files
committed
fix: color mismatch (#46)
1 parent 518fb29 commit 0bb0e45

File tree

4 files changed

+68
-68
lines changed

4 files changed

+68
-68
lines changed
Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
package com.raival.compose.file.explorer.common.compose
22

3+
import androidx.compose.foundation.background
4+
import androidx.compose.foundation.layout.Column
5+
import androidx.compose.foundation.layout.Row
36
import androidx.compose.foundation.layout.WindowInsets
47
import androidx.compose.foundation.layout.fillMaxSize
8+
import androidx.compose.foundation.layout.fillMaxWidth
59
import androidx.compose.foundation.layout.ime
610
import androidx.compose.foundation.layout.navigationBars
711
import androidx.compose.foundation.layout.statusBars
812
import androidx.compose.foundation.layout.windowInsetsPadding
9-
import androidx.compose.material3.MaterialTheme
13+
import androidx.compose.foundation.layout.wrapContentHeight
14+
import androidx.compose.material3.MaterialTheme.colorScheme
1015
import androidx.compose.material3.Surface
1116
import androidx.compose.runtime.Composable
1217
import androidx.compose.ui.Modifier
@@ -17,12 +22,21 @@ fun SafeSurface(
1722
content: @Composable () -> Unit
1823
) {
1924
Surface(
20-
modifier = Modifier.fillMaxSize()
25+
modifier = Modifier
26+
.fillMaxSize()
2127
.windowInsetsPadding(WindowInsets.navigationBars)
22-
.windowInsetsPadding(WindowInsets.statusBars)
2328
.windowInsetsPadding(WindowInsets.ime),
24-
color = MaterialTheme.colorScheme.surfaceContainerLowest
29+
color = colorScheme.surfaceContainerLowest
2530
) {
26-
content()
31+
Column(Modifier.fillMaxSize()) {
32+
Row(
33+
Modifier
34+
.fillMaxWidth()
35+
.wrapContentHeight()
36+
.background(color = colorScheme.surfaceContainer)
37+
.windowInsetsPadding(WindowInsets.statusBars)
38+
) {}
39+
content()
40+
}
2741
}
2842
}

app/src/main/java/com/raival/compose/file/explorer/screen/preferences/PreferencesActivity.kt

Lines changed: 49 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,35 @@ import android.annotation.SuppressLint
44
import android.os.Bundle
55
import androidx.activity.compose.setContent
66
import androidx.activity.enableEdgeToEdge
7+
import androidx.compose.foundation.background
78
import androidx.compose.foundation.layout.Column
9+
import androidx.compose.foundation.layout.Row
810
import androidx.compose.foundation.layout.fillMaxSize
11+
import androidx.compose.foundation.layout.fillMaxWidth
12+
import androidx.compose.foundation.layout.height
913
import androidx.compose.foundation.layout.padding
1014
import androidx.compose.foundation.rememberScrollState
1115
import androidx.compose.foundation.verticalScroll
16+
import androidx.compose.material.icons.Icons
17+
import androidx.compose.material.icons.automirrored.rounded.ArrowBack
18+
import androidx.compose.material3.Icon
19+
import androidx.compose.material3.IconButton
1220
import androidx.compose.material3.MaterialTheme.colorScheme
13-
import androidx.compose.material3.Scaffold
14-
import androidx.compose.material3.Surface
21+
import androidx.compose.material3.Text
22+
import androidx.compose.ui.Alignment
1523
import androidx.compose.ui.Modifier
24+
import androidx.compose.ui.res.stringResource
25+
import androidx.compose.ui.text.style.TextOverflow
1626
import androidx.compose.ui.unit.dp
27+
import androidx.compose.ui.unit.sp
28+
import com.raival.compose.file.explorer.R
1729
import com.raival.compose.file.explorer.base.BaseActivity
30+
import com.raival.compose.file.explorer.common.compose.SafeSurface
1831
import com.raival.compose.file.explorer.common.compose.Space
1932
import com.raival.compose.file.explorer.screen.preferences.compose.DisplayContainer
2033
import com.raival.compose.file.explorer.screen.preferences.compose.GeneralContainer
2134
import com.raival.compose.file.explorer.screen.preferences.compose.SingleChoiceDialog
2235
import com.raival.compose.file.explorer.screen.preferences.compose.TextEditorContainer
23-
import com.raival.compose.file.explorer.screen.preferences.compose.ToolbarView
2436
import com.raival.compose.file.explorer.ui.theme.FileExplorerTheme
2537

2638
class PreferencesActivity : BaseActivity() {
@@ -34,33 +46,45 @@ class PreferencesActivity : BaseActivity() {
3446
override fun onPermissionGranted() {
3547
setContent {
3648
FileExplorerTheme {
37-
Scaffold(
38-
topBar = { ToolbarView() }
39-
) { paddingValues ->
40-
Surface(
41-
modifier = Modifier.fillMaxSize(),
42-
color = colorScheme.surfaceContainerLowest
49+
SafeSurface(modifier = Modifier.fillMaxSize()) {
50+
Row(
51+
modifier = Modifier
52+
.fillMaxWidth()
53+
.height(64.dp)
54+
.background(color = colorScheme.surfaceContainer)
55+
.padding(horizontal = 4.dp),
56+
verticalAlignment = Alignment.CenterVertically
4357
) {
44-
SingleChoiceDialog()
58+
IconButton(onClick = { onBackPressedDispatcher.onBackPressed() }) {
59+
Icon(
60+
imageVector = Icons.AutoMirrored.Rounded.ArrowBack,
61+
contentDescription = null
62+
)
63+
}
4564
Column(
46-
Modifier
47-
.fillMaxSize()
48-
.verticalScroll(rememberScrollState())
49-
.padding(
50-
top = paddingValues.calculateTopPadding(),
51-
bottom = paddingValues.calculateBottomPadding()
52-
)
65+
Modifier.weight(1f)
5366
) {
54-
Space(size = 4.dp)
55-
56-
DisplayContainer()
57-
58-
GeneralContainer()
67+
Text(
68+
modifier = Modifier.fillMaxWidth(),
69+
text = stringResource(id = R.string.preferences),
70+
fontSize = 21.sp,
71+
maxLines = 1,
72+
overflow = TextOverflow.Ellipsis
73+
)
74+
}
75+
}
5976

60-
TextEditorContainer()
77+
SingleChoiceDialog()
6178

62-
Space(size = 4.dp)
63-
}
79+
Column(
80+
Modifier
81+
.fillMaxSize()
82+
.verticalScroll(rememberScrollState())) {
83+
Space(size = 4.dp)
84+
DisplayContainer()
85+
GeneralContainer()
86+
TextEditorContainer()
87+
Space(size = 4.dp)
6488
}
6589
}
6690
}

app/src/main/java/com/raival/compose/file/explorer/screen/preferences/compose/ToolbarView.kt

Lines changed: 0 additions & 36 deletions
This file was deleted.

app/src/main/java/com/raival/compose/file/explorer/ui/theme/Theme.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import androidx.compose.runtime.getValue
1717
import androidx.compose.runtime.mutableStateOf
1818
import androidx.compose.runtime.remember
1919
import androidx.compose.runtime.setValue
20-
import androidx.compose.ui.graphics.toArgb
2120
import androidx.compose.ui.platform.LocalContext
2221
import androidx.compose.ui.platform.LocalView
2322
import androidx.core.view.WindowCompat
@@ -73,7 +72,6 @@ fun FileExplorerTheme(
7372
if (!view.isInEditMode) {
7473
SideEffect {
7574
val window = (view.context as Activity).window
76-
window.statusBarColor = colorScheme.surfaceContainer.toArgb()
7775
WindowCompat.getInsetsController(window, view).isAppearanceLightStatusBars = !darkTheme
7876
}
7977
}

0 commit comments

Comments
 (0)