Setting up Fastlane

[IzzySoft]

Our scanners warned us that since the last version, your app has 14 APKs embedded. Checking what that might be, I find it's multiple Android Framework releases (frameworks/android/android-*.apk). May I ask why they are embedded there, and what they are used for? I can imagine some good reasons, but as none are pointed out in the app description I cannot be sure 😉

Speaking of app description (and graphics): would you mind establishing Fastlane structures (just the metadata, no need for the binaries) in your repo here? I could send you a starter package with what's set up at IzzyOnDroid currently, via PR, and you can use the IzzyOnDroid Fastlane Documentation for guidance when building on that. The big pro here would be that you'd be in control how your app is presented, and could easily keep descriptions and graphics in sync with latest development. Just let me know if you'd accept the PR – takes me less than 5 min to create it 😉

[Raival-e]

your app has 14 APKs embedded

well I had no clue these files existed, but after investigating when they were introduced in the app by checking the Github Action debug builds, it turns out they're relate to the APK Editor library, this library uses ARSCLib, and here you can find where these files come from.

Are those causes any safety problems? I honestly don't know what they're used for, I wanted to add advanced features to my app, such as those for APK editing, but if the library used here isn't trust worthy, I'd 100% be removing it and stick to basic APK editing functionality. The only feature implemented so far in my app is Anti-Split (Split APKs to APK) and APK Sign. I was planning to add more, but I should probably investigate a bit more about this before continuing.

would you mind establishing Fastlane structures...

I'd come back in few months and we'll talk about this, I'm so busy rn.

[IzzySoft]

it turns out they're relate to the APK Editor library

Yes, that makes a lot of sense – indeed it was the direction I thought (my own tooling includes Apktool for analyzing APKs, and it also comes with a framework APK). Thanks, added a note to the YAML linking here.

Are those causes any safety problems?

I don't think so. It's just that our APK scanner detected them, and it doesn't recurse into them, so I had to check.

I'd come back in few months and we'll talk about this, I'm so busy rn.

Fair enough, thanks! Though merging that PR would probably take just a few seconds, I can understand if you first want to find out what you're "dragging in there" and what it would mean in terms of maintenance (very little in fact: replacing some screenshots when the UI changed, updating the app description if changes suggest that). So for now, just keep in mind this offer stays, and please call me on it when you're ready for it. Until then, all the best! Feel free to keep this issue open as reminder for Fastlane, or close it as it's question was answered 😉

[Raival-e]

and please call me on it when you're ready for it

I'll sure do, thank you so much!

[Raival-e]

Hi again, I think we can carry on the Fastlane setup now, If you don't mind of course.

[IzzySoft]

Sure! You want me to send in a PR with what we have, as a "starter package with instructions"?

[Raival-e]

yes please

[IzzySoft]

There you go 😃

[Raival-e]

Thanks! I'll now update the app's details. I'll keep this open for any questions until I finish updating it.

[IzzySoft]

YAML updated here already:

  Fastlane: https://github.com/Raival-e/Prism-File-Explorer/tree/master/fastlane/metadata/android
  FastlaneFeatures: shortdesc,fulldescMD,icon,screenshots

Should you add other "FastlaneFeatures" (e.g. changelogs, featureGraphic), please let us know, so we check and enable them here as well.

[Raival-e]

Done. I have not added any additional Fastlane Features, maybe in the future, I'll let you know when I do that. Also, I've replaced the screenshots with new ones (now they're 7 instead of 3, and have generic names, not sure if you need to update anything on your side) 559137d

[Raival-e]

Btw, the changes will only update in the next release?

[IzzySoft]

Btw, the changes will only update in the next release?

Unless triggered manually, yes. That's when a fresh clone is pulled, and Fastlane gets updated from that. In urgent cases, we can pull in a fresh clone manually and update Fastlane from there – or pull in Fastlane updates directly, without a fresh clone. That should be reserved to "urgent cases", though, as it requires manual action. Done that now:

$ iod repo fastlane com.raival.compose.file.explorer -v
- Checking Fastlane for updates …
com.raival.compose.file.explorer: check if repo contains FUNDING.yml
com.raival.compose.file.explorer: FUNDING.yml already up-to-date.
com.raival.compose.file.explorer: calling 'getFastlaneMetaLocal('local',[host:localhost,owner:Raival-e,repo:Prism-File-Explorer,path:fastlane/metadata/android],0
com.raival.compose.file.explorer: FastlaneFeatures shortdesc,fulldescMD,icon,screenshots
com.raival.compose.file.explorer: parsing local fastlane in 'build/com.raival.compose.file.explorer/repo/fastlane/metadata/android'
com.raival.compose.file.explorer: checking locale 'en-US'
com.raival.compose.file.explorer: replacing 'build/com.raival.compose.file.explorer/metadata/en-US/full_description.txt' with fromMD
com.raival.compose.file.explorer: updating 'build/com.raival.compose.file.explorer/metadata/en-US/short_description.txt'
com.raival.compose.file.explorer: updating 'repo/com.raival.compose.file.explorer/en-US/icon.png'
com.raival.compose.file.explorer: updating 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/image1.png'
com.raival.compose.file.explorer: updating 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/image2.png'
com.raival.compose.file.explorer: updating 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/image3.png'
com.raival.compose.file.explorer: updating 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/image4.png'
com.raival.compose.file.explorer: updating 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/image5.png'
com.raival.compose.file.explorer: updating 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/image6.png'
com.raival.compose.file.explorer: updating 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/image7.png'
com.raival.compose.file.explorer: cross-checking for obsolete screenshots
com.raival.compose.file.explorer: screenshots in Fastlane: image1,image2,image3,image4,image5,image6,image7
com.raival.compose.file.explorer: removing 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/home_screen.png'
com.raival.compose.file.explorer: removing 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/options_dialog.png'
com.raival.compose.file.explorer: removing 'repo/com.raival.compose.file.explorer/en-US/phoneScreenshots/text_editor.png'
com.raival.compose.file.explorer: local screenshots checked: home_screen,image1,image2,image3,image4,image5,image6,image7,options_dialog,text_editor

So it should be reflected with the next sync around 6 pm UTC; you can check then if it meets your expectation 😉

[Raival-e]

Thanks!