Trinkets Compat

[Vixeliz]

Describe the feature

This may already be done but I couldn't find any info confirming it. I am using ElytraSlots with Trinkets. And I was wondering does this mod also take account items equipped in trinket slots? I think it would be a nice addition if it doesn't.

[Rakambda]

I don't know at all. As a guess I'd say no but needs to be tested to be sure.

As it is I get the player inventory and scans everything in it. Though i don't know how trinkets works internally. Either it handles the new inventory by itself, or it is somehow added to the player inventory (in which case it'd work).

I'll check a bit later on.

[Vixeliz]

I can't say 100% sure but I did some testing of my own and I can say with 99% confidence overpowered mending does not appear to work with things in trinket slots.

[Vixeliz]

Seems like trinket provides an api for looping over all of the trinkets on an entity (https://github.com/emilyploszaj/trinkets/wiki/Trinkets-API). This could be something I possibly could work on and make a pr if you are uninterested in implementing it.

[Rakambda]

I see, so the issue was more like a request rather than a question, I didn't understand it that way sorry.

But yeah seems "normal" to me, probably need to use their API to bring compatibility.
Just to be sure, we're talking about Trinkets, but seems like that mod doesn't use Trinkets right? It seems to be Curios instead.

[Vixeliz]

ElytraSlot uses curios for forge I believe then trinkets for fabric. And yes I meant more of a request but obviously no pressure to implement if you are uninterested just thought I would bring it up. If i were to make a pr I have no knowledge about forge modding but may be able to do fabric if that is something you are interested in. Also thanks for the awesome mod!

[Rakambda]

I recreated the issue #104