Skip to content

Commit 3a6960e

Browse files
committed
Fix boundary breaking password generation bug
Fixes a bug that could allow for passwords to be generated with lengths of up to ~32,000.
1 parent 4a09b69 commit 3a6960e

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

api/.nextRelease/api.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ class Generator {
366366
max = min;
367367
}
368368
min = min > 64 || min < 1 || min === undefined || isNaN(min) ? 8 : min;
369-
max = max > 64 || max < 1 || max === undefined || isNaN(max) ? 64 : max;
369+
max = max > 64 || max < 1 || max === undefined || isNaN(max) || max < min ? 64 : max;
370370

371371
let passLen = range(min, max);
372372

api/1.1/api.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ class Generator {
335335
max = min;
336336
}
337337
min = min > 64 || min < 1 || min === undefined || isNaN(min) ? 8 : min;
338-
max = max > 64 || max < 1 || max === undefined || isNaN(max) ? 64 : max;
338+
max = max > 64 || max < 1 || max === undefined || isNaN(max) || max < min ? 64 : max;
339339

340340
let passLen = range(min, max);
341341

api/1.2/api.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ class Generator {
363363
max = min;
364364
}
365365
min = min > 64 || min < 1 || min === undefined || isNaN(min) ? 8 : min;
366-
max = max > 64 || max < 1 || max === undefined || isNaN(max) ? 64 : max;
366+
max = max > 64 || max < 1 || max === undefined || isNaN(max) || max < min ? 64 : max;
367367

368368
let passLen = range(min, max);
369369

api/1.3/api.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ class Generator {
366366
max = min;
367367
}
368368
min = min > 64 || min < 1 || min === undefined || isNaN(min) ? 8 : min;
369-
max = max > 64 || max < 1 || max === undefined || isNaN(max) ? 64 : max;
369+
max = max > 64 || max < 1 || max === undefined || isNaN(max) || max < min ? 64 : max;
370370

371371
let passLen = range(min, max);
372372

0 commit comments

Comments
 (0)