Skip to content

Commit 61696bf

Browse files
committed
Fixed issue when using multiple audio encodings, with the last encoding name clobbering the others.
1 parent 2232d81 commit 61696bf

File tree

2 files changed

+4
-29
lines changed

2 files changed

+4
-29
lines changed

VidCoder/ViewModel/MainViewModel.cs

Lines changed: 3 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1284,40 +1284,15 @@ private void BuildAudioViewModelList()
12841284
.Select(track => new AudioTrackViewModel(this, track, new ChosenAudioTrack { TrackNumber = track.TrackNumber }) { Selected = true }));
12851285
}
12861286

1287-
// Fill in rest of unselected audio tracks
1288-
this.FillInUnselectedAudioTracks(audioTracksInnerList);
1289-
1290-
// Apply audio names from the Picker and Audio Encoding settings.
1287+
// Apply audio names from the Picker.
12911288
int outputIndex = 0;
12921289
foreach (AudioTrackViewModel audioTrackViewModel in audioTracksInnerList)
12931290
{
12941291
audioTrackViewModel.Name = ProcessingService.GetPickerAudioName(picker, outputIndex++);
12951292
}
12961293

1297-
VCProfile profile = this.PresetsService.SelectedPreset.Preset.EncodingProfile;
1298-
if (profile.AudioEncodings != null)
1299-
{
1300-
foreach (AudioEncoding audioEncoding in profile.AudioEncodings)
1301-
{
1302-
if (string.IsNullOrEmpty(audioEncoding.Name))
1303-
{
1304-
continue;
1305-
}
1306-
1307-
if (audioEncoding.InputNumber == 0)
1308-
{
1309-
foreach (AudioTrackViewModel audioTrackViewModel in audioTracksInnerList)
1310-
{
1311-
audioTrackViewModel.Name = audioEncoding.Name;
1312-
}
1313-
}
1314-
else if (audioEncoding.InputNumber <= audioTracksInnerList.Count)
1315-
{
1316-
AudioTrackViewModel audioTrackViewModel = audioTracksInnerList[audioEncoding.InputNumber - 1];
1317-
audioTrackViewModel.Name = audioEncoding.Name;
1318-
}
1319-
}
1320-
}
1294+
// Fill in rest of unselected audio tracks
1295+
this.FillInUnselectedAudioTracks(audioTracksInnerList);
13211296
});
13221297
}
13231298

VidCoderCommon/Model/JsonEncodeFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ private static List<ResolvedAudioTrack> ResolveAudioTracks(List<PairedAudioTrack
291291
Encoder = HandBrakeEncoderHelpers.GetAudioEncoder((int)outputCodec).ShortName,
292292
};
293293

294-
// First priority: Chosen track name in the UI
294+
// First priority: Chosen track name in the UI / Picker
295295
string trackName = chosenTrack.Name;
296296

297297
// Second priority name set in Audio Encoding

0 commit comments

Comments
 (0)