Skip to content

Commit 2fbdc77

Browse files
#64 Excel xml and html data.preview patch changes & docs update
1 parent 31d6394 commit 2fbdc77

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,7 @@ Data File Extension(s) | File Type | Data Parsing Library/Method Used | Data For
138138
`.ini` | text | [node-properties](https://github.com/gagle/node-properties)/[`properties.parse()`](https://github.com/gagle/node-properties#ini) | https://en.wikipedia.org/wiki/INI_file
139139
`.yml` `.yaml` | text | [js-yaml](https://github.com/nodeca/js-yaml)/[`yaml.load()`](https://github.com/nodeca/js-yaml#load-string---options-) | https://yaml.org/
140140
`.csv` `.tsv` `.txt` `.tab` | text | [perspective](https://github.com/finos/perspective/)/[`perspectiveViewer.load(text)`](https://github.com/finos/perspective/tree/master/packages/perspective-viewer#module_perspective-viewer..PerspectiveViewer+load) | https://en.wikipedia.org/wiki/Comma-separated_values https://en.wikipedia.org/wiki/Tab-separated_values
141-
`.xml` `.html` | text | [js-xlsx](https://github.com/SheetJS/js-xlsx)/[`XLSX.read(string)`](https://github.com/SheetJS/js-xlsx#parsing-functions) | See https://github.com/SheetJS/js-xlsx#file-formats for more info on text `Excel` file formats
142-
`.dif` `.ods` `.slk` `.xls` `.xlsb` `.xlsx` `.xlsm` | binary | [js-xlsx](https://github.com/SheetJS/js-xlsx)/[`XLSX.read(buffer)`](https://github.com/SheetJS/js-xlsx#parsing-functions) | See https://github.com/SheetJS/js-xlsx#file-formats for more info on binary `Excel` file formats
141+
`.dif` `.ods` `.slk` `.xls` `.xlsb` `.xlsx` `.xlsm` `.xml` `.html` | binary/text | [js-xlsx](https://github.com/SheetJS/js-xlsx)/[`XLSX.read()`](https://github.com/SheetJS/js-xlsx#parsing-functions) | See https://github.com/SheetJS/js-xlsx#file-formats for more info on `Excel` file formats
143142

144143
![Data Preview Data](https://github.com/RandomFractals/vscode-data-preview/blob/master/images/vscode-data-preview-data.png?raw=true
145144
"Data Preview Data")

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "vscode-data-preview",
33
"displayName": "Data Preview",
44
"description": "Data Preview 🈸 extension for viewing 🔎 slicing 🔪 dicing 🎲 & charting 📊 large JSON array/config, YAML, Apache Arrow, Avro & Excel data files",
5-
"version": "1.20.0",
5+
"version": "1.20.1",
66
"icon": "images/data-preview.png",
77
"publisher": "RandomFractalsInc",
88
"author": "Taras Novak",

src/data.preview.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -480,11 +480,9 @@ export class DataPreview {
480480
case '.xlsb':
481481
case '.xlsx':
482482
case '.xlsm':
483-
data = this.getBinaryExcelData(dataFilePath);
484-
break;
485483
case '.xml':
486-
case '.html':
487-
data = this.getTextExcelData(dataFilePath);
484+
case '.html':
485+
data = this.getBinaryExcelData(dataFilePath);
488486
break;
489487
case '.env':
490488
data = jsonUtils.configToPropertyArray(fs.readFileSync(dataFilePath, 'utf8'));

0 commit comments

Comments
 (0)