Skip to content

Commit 41a0cae

Browse files
#15 file utils remote data load todo comments cleanup
1 parent 9bb5312 commit 41a0cae

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/utils/file.utils.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ export function createJsonFile(jsonFilePath: string, jsonData: any): void {
9898
* Reads local file data.
9999
* @param dataFilePath Data file path.
100100
* @param encoding Data file encoding: 'utf8' for text data files, null for binary data reads.
101-
* TODO: change this to read data async later
102-
* TODO: rework this to using fs.ReadStream for large data files support later
103101
*/
104102
async function readLocalData(dataFilePath: string, encoding: string = null): Promise<string | Buffer> {
105103
logger.debug('readLocalData():', dataFilePath);
@@ -111,8 +109,6 @@ async function readLocalData(dataFilePath: string, encoding: string = null): Pro
111109
* Reads remote file data.
112110
* @param dataUrl Data file url.
113111
* @param encoding Data file encoding: 'utf8' for text data files, null for binary data reads.
114-
* TODO: change this to read data async later
115-
* TODO: rework this to using streaming api for large data files support later
116112
*/
117113
async function readRemoteData(dataUrl: string, encoding: string = null): Promise<string | Buffer> {
118114
logger.debug('readRemoteData(): url:', dataUrl);

0 commit comments

Comments
 (0)