Skip to content

Commit a08f71b

Browse files
#141 switched to Uri.file instead of parse for local data file reads
1 parent ac5c69f commit a08f71b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/data.preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ export class DataPreview {
681681
*/
682682
private logDataStats(dataRows: Array<any>, dataSchema: any = null): void {
683683
// get data file size in bytes
684-
this._fileSize = fileUtils.getFileSize(this._dataUrl);
684+
this._fileSize = fileUtils.getFileSize(this._uri.fsPath); //this._dataUrl);
685685
this._rowCount = dataRows.length;
686686
this.updateStats(this._columns, this._rowCount);
687687
if (this.logLevel === 'debug') {

src/utils/file.utils.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const logger: Logger = new Logger(`file.utils:`, config.logLevel);
1616
export function readDataFile(dataFilePath: string, encoding:string = null) {
1717
let data: any = '';
1818
const fileName: string = path.basename(dataFilePath);
19-
const fileUri: Uri = Uri.parse(dataFilePath);
19+
const fileUri: Uri = Uri.file(dataFilePath); // .parse(dataFilePath);
2020
logger.debug('readDataFile():', dataFilePath);
2121
if (!config.supportedDataFiles.test(fileName)) {
2222
window.showErrorMessage(`${dataFilePath} is not a supported data file for Data Preview!`);
@@ -36,7 +36,7 @@ export function readDataFile(dataFilePath: string, encoding:string = null) {
3636
workspace.findFiles(`**/${dataFilePath}`).then(files => {
3737
if (files.length > 0 && fs.existsSync(files[0].fsPath)) {
3838
// read workspace file data
39-
data = readLocalData(dataFilePath, encoding);
39+
data = readLocalData(files[0].fsPath, encoding);
4040
} else {
4141
window.showErrorMessage(`${dataFilePath} file doesn't exist!`);
4242
}
@@ -51,7 +51,7 @@ export function readDataFile(dataFilePath: string, encoding:string = null) {
5151
*/
5252
export function getFileSize(dataFilePath: string): number {
5353
let fileSize: number = -1;
54-
const fileUri: Uri = Uri.parse(dataFilePath);
54+
const fileUri: Uri = Uri.file(dataFilePath); //.parse(dataFilePath);
5555
if (fs.existsSync(fileUri.fsPath)) {
5656
const stats: fs.Stats = fs.statSync(fileUri.fsPath);
5757
fileSize = stats.size;

0 commit comments

Comments
 (0)