Skip to content

Commit af2c3c0

Browse files
csv/json data preview patch after adding data schema for arrow data files
1 parent 3867887 commit af2c3c0

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "vscode-data-preview",
33
"displayName": "Data Preview",
44
"description": "Data Preview",
5-
"version": "1.5.0",
5+
"version": "1.5.1",
66
"publisher": "RandomFractalsInc",
77
"author": "Taras Novak",
88
"contributors": [
@@ -25,7 +25,8 @@
2525
"json",
2626
"json data",
2727
"arrow",
28-
"arrow data"
28+
"arrow data",
29+
"excel"
2930
],
3031
"engines": {
3132
"vscode": "^1.32.3"

templates/data.preview.html

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,16 @@
9898
// initialize perspective viewer
9999
console.log(`data.preview:refresh(): initializing view data for: ${data.fileName}`);
100100
viewer.restore(viewConfig);
101-
// viewer.columns = viewConfig['columns'];
102-
viewer.load(data.schema);
103-
viewer.update(tableData);
101+
if (data.schema !== undefined && Object.keys(data.schema).length > 0) {
102+
// viewer.columns = viewConfig['columns'];
103+
viewer.load(data.schema);
104+
viewer.update(tableData);
105+
}
106+
else {
107+
viewer.load(tableData);
108+
}
104109
viewer.toggleConfig();
105-
} else {
106-
// update viewer data without toggles reset
110+
} else { // update viewer data without toggles reset
107111
console.log(`data.preview:refresh(): updating view data for: ${data.fileName}`);
108112
viewer.clear();
109113
viewer.update(tableData);

0 commit comments

Comments
 (0)