Set edition and fix clippy lints (#21)

* add edition
* clone fixes
* crate prefixes
* redundant named args
* non anonymous args

Author: stargazing-dino

Cargo.toml

@@ -2,6 +2,7 @@
 name = "pscontroller-rs"
 version = "0.7.0"
 authors = ["Edwin Amsler"]
+edition = "2018"
 
 categories = ["embedded", "hardware-support", "no-std"]
 description = "A hardware-level platform agnostic driver for PlayStation 1 or 2 contoller peripherals. Requires soldering. 😁"

src/classic.rs

@@ -134,6 +134,6 @@ pub struct Classic {
 
 impl HasStandardButtons for Classic {
     fn buttons(&self) -> GamepadButtons {
-        self.buttons.clone()
+        self.buttons
     }
 }

src/dualshock.rs

@@ -6,7 +6,7 @@
 //! This also maps for the the Dual Analog (precursor to the Dual Shock) and
 //! the Analog controller (flight stick) as they both have the same buttons
 
-use classic::GamepadButtons;
+use crate::classic::GamepadButtons;
 use super::{
     HasStandardButtons,
     PollCommand
@@ -31,7 +31,7 @@ pub struct DualShock {
 
 impl HasStandardButtons for DualShock {
     fn buttons(&self) -> GamepadButtons {
-        self.buttons.clone()
+        self.buttons
     }
 }
 
@@ -58,7 +58,7 @@ pub struct DualShock2 {
 
 impl HasStandardButtons for DualShock2 {
     fn buttons(&self) -> GamepadButtons {
-        self.buttons.clone()
+        self.buttons
     }
 }
 
@@ -75,8 +75,8 @@ impl ControlDS {
     /// Create a new one of thes newfangled control commands
     pub fn new(little: bool, big: u8) -> Self {
         Self {
-            little: little,
-            big: big,
+            little,
+            big,
         }
     }
 }

src/guitarhero.rs

@@ -95,6 +95,6 @@ pub struct GuitarHero {
 impl GuitarHero {
     /// Get a copy of the buttons that were pressed
     pub fn buttons(&self) -> GuitarButtons {
-        self.buttons.clone()
+        self.buttons
     }
 }

src/jogcon.rs

@@ -5,7 +5,7 @@
 //! but it is featureful enough that it can be treated as a servo motor with
 //! little effort.
 
-use classic::GamepadButtons;
+use crate::classic::GamepadButtons;
 use byteorder::{
     ByteOrder,
     LittleEndian
@@ -73,7 +73,7 @@ impl JogCon {
 
 impl HasStandardButtons for JogCon {
     fn buttons(&self) -> GamepadButtons {
-        self.buttons.clone()
+        self.buttons
     }
 }
 
@@ -89,8 +89,8 @@ impl ControlJC {
     /// Create a new one of thes newfangled control commands
     pub fn new(mode: JogControl, strength: u8) -> Self {
         Self {
-            mode: mode,
-            strength: strength,
+            mode,
+            strength,
         }
     }
 }

src/lib.rs

@@ -204,7 +204,7 @@ pub trait PollCommand {
     /// Re-write the provided slice starting from index 0. This command
     /// is called by read_input() which will provide a sub-slice of the
     /// controller's command bytes.
-    fn set_command(&self, &mut [u8]);
+    fn set_command(&self, _: &mut [u8]);
 }
 
 /// Many controllers have the same set of buttons (Square, Circle, L3, R1, etc).
@@ -416,7 +416,7 @@ where
         Ok(config)
     }
 
-    fn read_port(&mut self, command: Option<&PollCommand>) -> Result<[u8; MESSAGE_MAX_LENGTH], Error<E>> {
+    fn read_port(&mut self, command: Option<&dyn PollCommand>) -> Result<[u8; MESSAGE_MAX_LENGTH], Error<E>> {
         let mut buffer = [0u8; MESSAGE_MAX_LENGTH];
         let mut data = [0u8; MESSAGE_MAX_LENGTH];
 
@@ -448,7 +448,7 @@ where
     /// Get the raw data from polling for a controller. You can use this to cooerce the data into
     /// some controller that can't be safely identified by `read_input`, but you should rely on that
     /// function if you can.
-    pub fn read_raw(&mut self, command: Option<&PollCommand>) -> Result<ControllerData, Error<E>> {
+    pub fn read_raw(&mut self, command: Option<&dyn PollCommand>) -> Result<ControllerData, Error<E>> {
         let mut buffer = [0u8; MESSAGE_MAX_LENGTH];
         let data = self.read_port(command)?;
 
@@ -463,7 +463,7 @@ where
 
     /// Ask the controller for input states. Different contoller types will be returned automatically
     /// for you. If you'd like to cooerce a controller yourself, use `read_raw`.
-    pub fn read_input(&mut self, command: Option<&PollCommand>) -> Result<Device, Error<E>> {
+    pub fn read_input(&mut self, command: Option<&dyn PollCommand>) -> Result<Device, Error<E>> {
         let mut buffer = [0u8; MESSAGE_MAX_LENGTH];
         let data = self.read_port(command)?;