Fix regression in mechanism to hold objects while emitting

Author: RandomShaper

core/object/object.cpp

@@ -1221,6 +1221,10 @@ Error Object::emit_signalp(const StringName &p_name, const Variant **p_args, int
 	uint32_t *slot_flags = slot_flags_stack;
 	uint32_t slot_count = 0;
 
+	// If this is a ref-counted object, prevent it from being destroyed during signal emission,
+	// which is needed in certain edge cases; e.g., GH-73889 and GH-109471.
+	Ref<RefCounted> extra_rc = Ref<RefCounted>(Object::cast_to<RefCounted>(this));
+
 	{
 		OBJ_SIGNAL_LOCK
 
@@ -1235,10 +1239,6 @@ Error Object::emit_signalp(const StringName &p_name, const Variant **p_args, int
 			return ERR_UNAVAILABLE;
 		}
 
-		// If this is a ref-counted object, prevent it from being destroyed during signal emission,
-		// which is needed in certain edge cases; e.g., https://github.com/godotengine/godot/issues/73889.
-		Ref<RefCounted> rc = Ref<RefCounted>(Object::cast_to<RefCounted>(this));
-
 		if (s->slot_map.size() > MAX_SLOTS_ON_STACK) {
 			slot_callables = (Callable *)memalloc(sizeof(Callable) * s->slot_map.size());
 			slot_flags = (uint32_t *)memalloc(sizeof(uint32_t) * s->slot_map.size());
@@ -1320,6 +1320,8 @@ Error Object::emit_signalp(const StringName &p_name, const Variant **p_args, int
 		memfree(slot_flags);
 	}
 
+	(void)extra_rc; // Ensure it's scoped to the function so it lives up to the end.
+
 	return err;
 }