Draw to texture fix (#401)

* Commit in blit

Closes #286

* Fix shatter samples

This extra commit ensures that the demos work on macOS

Same error as in #286

* Inline cf_commit

This change inlines cf_commit into cf_draw_elements so that it does not need to be called separately.

* Update docs after cf_commit removal

Author: pusewicz

docs/topics/low_level_graphics.md

@@ -38,7 +38,6 @@ for each canvas {
             }
         }
     }
-    cf_commit();
 }
 ```
 
@@ -48,7 +47,6 @@ The important functions are are the apply functions. Each apply function is used
 - [`cf_apply_mesh`](../graphics/cf_apply_mesh.md)
 - [`cf_apply_shader`](../graphics/cf_apply_shader.md)
 - [`cf_draw_elements`](../graphics/cf_draw_elements.md)
-- [`cf_commit`](../graphics/cf_commit.md)
 
 ## Meshes
 

docs/topics/renderer.md

@@ -359,7 +359,6 @@ CF renders through `SDL_Gpu`(https://wiki.libsdl.org/SDL3/CategoryGPU), a well-w
  *                 for each shader {
  *                     cf_apply_shader(shader, material);
  *                     cf_draw_elements(...);
- *                     cf_commit();
  *                 }
  *             }
  *         }
@@ -561,4 +560,4 @@ If you're familiar with Unity's old surface shaders, this is very similar in con
 
 # Conclusion
 
-And that's it! The CF renderer design offers a very high-performance batching solution, unifying rendering sprites, shapes, and text all together. It also offers shader customization that can be applied to renderable items (as well as canvases), making for a unique and effective renderer API.
+And that's it! The CF renderer design offers a very high-performance batching solution, unifying rendering sprites, shapes, and text all together. It also offers shader customization that can be applied to renderable items (as well as canvases), making for a unique and effective renderer API.

include/cute_graphics.h

@@ -53,7 +53,6 @@ extern "C" {
  *                 }
  *             }
  *         }
- *         cf_commit();
  *     }
  */
 
@@ -1878,15 +1877,6 @@ CF_API void CF_CALL cf_apply_shader(CF_Shader shader, CF_Material material);
  */
 CF_API void CF_CALL cf_draw_elements(void);
 
-/**
- * @function cf_commit
- * @category graphics
- * @brief    Submits all previous draw commands to the GPU.
- * @remarks  You must call this after calling `cf_apply_shader` to "complete" the rendering pass.
- * @related  CF_Canvas cf_apply_canvas cf_apply_mesh cf_apply_shader
- */
-CF_API void CF_CALL cf_commit(void);
-
 #ifdef __cplusplus
 }
 #endif // __cplusplus
@@ -1941,7 +1931,6 @@ CF_INLINE void apply_scissor(int x, int y, int w, int h) { cf_apply_scissor(x, y
 CF_INLINE void apply_mesh(CF_Mesh mesh) { cf_apply_mesh(mesh); }
 CF_INLINE void apply_shader(CF_Shader shader, CF_Material material) { cf_apply_shader(shader, material); }
 CF_INLINE void draw_elements() { cf_draw_elements(); }
-CF_INLINE void commit() { cf_commit(); }
 
 }
 void cf_clear_canvas(CF_Canvas canvas_handle);

samples/basic_indexed_rendering.c

@@ -68,7 +68,6 @@ int main(int argc, char* argv[])
 		cf_apply_mesh(mesh);
 		cf_apply_shader(shader, material);
 		cf_draw_elements();
-		cf_commit();
 		cf_app_draw_onto_screen(false);
 	}
 

samples/basic_instancing.c

@@ -86,7 +86,6 @@ int main(int argc, char* argv[])
 		cf_apply_mesh(mesh);
 		cf_apply_shader(shader, material);
 		cf_draw_elements();
-		cf_commit();
 		cf_app_draw_onto_screen(false);
 	}
 

samples/hello_triangle.c

@@ -83,7 +83,6 @@ int main(int argc, char* argv[])
 		cf_apply_mesh(mesh);
 		cf_apply_shader(shader, material);
 		cf_draw_elements();
-		cf_commit();
 
 		cf_app_draw_onto_screen(false);
 	}

src/cute_draw.cpp

@@ -381,7 +381,6 @@ static void s_draw_report(spritebatch_sprite_t* sprites, int count, int texture_
 	}
 
 	cf_draw_elements();
-	cf_commit();
 
 	draw->has_drawn_something = true;
 }

src/cute_graphics.cpp

@@ -649,16 +649,3 @@ void cf_draw_elements()
 #endif
 	}
 }
-
-void cf_sdlgpu_commit();
-void cf_gles_commit();
-void cf_commit()
-{
-	if (app->gfx_backend_type == CF_BACKEND_TYPE_GLES3) {
-		cf_gles_commit();
-	} else {
-#ifndef CF_EMSCRIPTEN
-		cf_sdlgpu_commit();
-#endif
-	}
-}

src/cute_graphics_gles.cpp

@@ -1648,10 +1648,6 @@ void cf_gles_draw_elements()
 
 	CF_POLL_OPENGL_ERROR();
 	++app->draw_call_count;
-}
-
-void cf_gles_commit()
-{
 	g_ctx.target_state = s_default_state(g_ctx.canvas);
 }
 

src/cute_graphics_sdlgpu.cpp

@@ -1528,10 +1528,7 @@ void cf_sdlgpu_draw_elements()
 		}
 	}
 	app->draw_call_count++;
-}
 
-void cf_sdlgpu_commit()
-{
 	SDL_EndGPURenderPass(g_ctx.canvas->pass);
 }