Skip to content

Commit 53e595a

Browse files
committed
Build and package in one step
1 parent 81e4b51 commit 53e595a

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

.github/workflows/ci.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -123,25 +123,25 @@ jobs:
123123

124124
# Build
125125
- name: Build (Unix)
126-
if: matrix.os != 'windows-latest'
127-
run: cmake --build build-Release --parallel
128-
129-
- name: Build (Windows)
130-
if: matrix.os == 'windows-latest'
131-
run: cmake --build build-Release --parallel
132-
shell: pwsh
133-
134-
# Package
135-
- name: CPack (Unix)
136126
if: matrix.os != 'windows-latest'
137127
run: cmake --build build-Release --target package --parallel
138-
continue-on-error: true
139128

140-
- name: CPack (Windows)
129+
- name: Build (Windows)
141130
if: matrix.os == 'windows-latest'
142131
run: cmake --build build-Release --target package --parallel
143132
shell: pwsh
144-
continue-on-error: true
133+
134+
# # Package
135+
# - name: CPack (Unix)
136+
# if: matrix.os != 'windows-latest'
137+
# run: cmake --build build-Release --target package --parallel
138+
# continue-on-error: true
139+
#
140+
# - name: CPack (Windows)
141+
# if: matrix.os == 'windows-latest'
142+
# run: cmake --build build-Release --target package --parallel
143+
# shell: pwsh
144+
# continue-on-error: true
145145

146146
# Artifacts
147147
- name: Upload packages

src/cloud-client/CMakeLists.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@ elseif (APPLE)
7272
set_source_files_properties("${APP_ICON}" PROPERTIES MACOSX_PACKAGE_LOCATION "Resources")
7373
target_sources(cloud-client PRIVATE "${APP_ICON}")
7474

75-
#add_custom_command(TARGET cloud-client POST_BUILD
76-
# COMMAND /usr/libexec/PlistBuddy -c "Set :CFBundleName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist" || /usr/libexec/PlistBuddy -c "Add :CFBundleName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist"
77-
# COMMAND /usr/libexec/PlistBuddy -c "Set :CFBundleDisplayName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist" || /usr/libexec/PlistBuddy -c "Add :CFBundleDisplayName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist"
78-
# COMMENT "Set CFBundleDisplayName"
79-
#)
75+
add_custom_command(TARGET cloud-client POST_BUILD
76+
COMMAND /usr/libexec/PlistBuddy -c "Set :CFBundleName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist" || /usr/libexec/PlistBuddy -c "Add :CFBundleName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist"
77+
COMMAND /usr/libexec/PlistBuddy -c "Set :CFBundleDisplayName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist" || /usr/libexec/PlistBuddy -c "Add :CFBundleDisplayName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist"
78+
COMMENT "Set CFBundleDisplayName"
79+
)
8080
endif()
8181

8282
qt_add_resources(cloud-client icons-application

0 commit comments

Comments
 (0)