Skip to content

Commit ca0f78f

Browse files
committed
Upload per OS
1 parent 3c7a059 commit ca0f78f

File tree

2 files changed

+19
-3
lines changed

2 files changed

+19
-3
lines changed

.github/workflows/ci.yml

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,8 @@ jobs:
144144
continue-on-error: true
145145

146146
# Artifacts
147-
- name: Upload packages
147+
- name: Upload packages (Linux)
148+
if: matrix.os == 'ubuntu-latest'
148149
uses: actions/upload-artifact@v4
149150
with:
150151
name: ${{ github.event.repository.name }}-${{ matrix.os }}-${{ matrix.arch }}-packages
@@ -155,7 +156,24 @@ jobs:
155156
build-Release/${{ github.event.repository.name }}-*.run
156157
build-Release/${{ github.event.repository.name }}-*.zip
157158
build-Release/${{ github.event.repository.name }}-*.tar.gz
159+
if-no-files-found: error
160+
161+
- name: Upload packages (Macos)
162+
if: matrix.os == 'macos-latest'
163+
uses: actions/upload-artifact@v4
164+
with:
165+
name: ${{ github.event.repository.name }}-${{ matrix.os }}-${{ matrix.arch }}-packages
166+
path: |
158167
build-Release/${{ github.event.repository.name }}-*.dmg
168+
if-no-files-found: error
169+
170+
- name: Upload packages (Windows)
171+
if: matrix.os == 'windows-latest'
172+
uses: actions/upload-artifact@v4
173+
with:
174+
name: ${{ github.event.repository.name }}-${{ matrix.os }}-${{ matrix.arch }}-packages
175+
path: |
176+
build-Release/${{ github.event.repository.name }}-*.zip
159177
build-Release/${{ github.event.repository.name }}-*.exe
160178
if-no-files-found: error
161179

src/cloud-client/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ set_target_properties(cloud-client
5656
WIN32_EXECUTABLE TRUE
5757
MACOSX_BUNDLE TRUE
5858
MACOSX_BUNDLE_ICON_FILE "${PROJECT_PACKAGE_NAME}"
59-
MACOSX_BUNDLE_BUNDLE_NAME "${PROJECT_SHORT_NAME}"
6059
)
6160

6261
if (WIN32)
@@ -75,7 +74,6 @@ elseif (APPLE)
7574
add_custom_command(TARGET cloud-client POST_BUILD
7675
COMMAND /usr/libexec/PlistBuddy -c "Set :CFBundleName '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist"
7776
COMMAND /usr/libexec/PlistBuddy -c "Add :CFBundleDisplayName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist"
78-
# COMMAND /usr/libexec/PlistBuddy -c "Set :CFBundleDisplayName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist" || /usr/libexec/PlistBuddy -c "Add :CFBundleDisplayName string '${PROJECT_SHORT_NAME}'" "$<TARGET_BUNDLE_DIR_NAME:${PROJECT_TARGET_NAME}>/Contents/Info.plist"
7977
COMMENT "Set CFBundleDisplayName"
8078
)
8179
endif()

0 commit comments

Comments
 (0)