Fixed some compiler warnings

Author: tomas-soltys

range/Range/src/action.cpp

@@ -263,11 +263,9 @@ void Action::onModelOpen()
 
 void Action::onModelSave()
 {
-    QList<uint> selectedModelIDs = Session::getInstance().getSelectedModelIDs();
-
-    for (int i=0;i<selectedModelIDs.size();i++)
+    foreach (uint selectedModelID,Session::getInstance().getSelectedModelIDs())
     {
-        Model &rModel = Session::getInstance().getModel(selectedModelIDs[i]);
+        Model &rModel = Session::getInstance().getModel(selectedModelID);
 
         QString fileName = ModelIO::getModelSaveName(MainSettings::getInstance(),this->mainWindow,rModel);
 
@@ -1218,13 +1216,11 @@ void Action::onGeometrySurfaceCloseHole()
         return;
     }
 
-    QList<uint> modelIDs = pickList.getModelIDs();
-
-    for (int i=0;i<modelIDs.size();i++)
+    foreach (uint modelID,pickList.getModelIDs())
     {
         QList<uint> holeIDs;
 
-        QVector<PickItem> pickItems = pickList.getItems(modelIDs[i]);
+        QVector<PickItem> pickItems = pickList.getItems(modelID);
         for (int j=0;j<pickItems.size();j++)
         {
             if (pickItems[j].getItemType() == PICK_ITEM_HOLE_ELEMENT)
@@ -1238,7 +1234,7 @@ void Action::onGeometrySurfaceCloseHole()
             }
         }
 
-        ModelActionInput modelActionInput(modelIDs[i]);
+        ModelActionInput modelActionInput(modelID);
         modelActionInput.setCloseSurfaceHole(holeIDs);
 
         ModelAction *modelAction = new ModelAction;

range/Range/src/action_definition.cpp

@@ -90,11 +90,11 @@ QList<ActionType> ActionDefinition::getActionTypes(ActionGroupTypeMask actionGro
 {
     QList<ActionType> actionTypes;
 
-    for (int i=0;i<this->actionDesc.size();i++)
+    foreach (ActionDefinitionItem item, this->actionDesc)
     {
-        if (this->actionDesc[i].getGroupType() & actionGroupTypeMask)
+        if (item.getGroupType() & actionGroupTypeMask)
         {
-            actionTypes.push_back(this->actionDesc[i].getType());
+            actionTypes.push_back(item.getType());
         }
     }
 

range/Range/src/action_definition_item.cpp

@@ -55,17 +55,17 @@ ActionDefinitionItem &ActionDefinitionItem::operator =(const ActionDefinitionIte
     return (*this);
 }
 
-ActionType ActionDefinitionItem::getType(void) const
+ActionType ActionDefinitionItem::getType() const
 {
     return this->type;
 }
 
-ActionGroupType ActionDefinitionItem::getGroupType(void) const
+ActionGroupType ActionDefinitionItem::getGroupType() const
 {
     return this->groupType;
 }
 
-const QString &ActionDefinitionItem::getShortcut(void) const
+const QString &ActionDefinitionItem::getShortcut() const
 {
     return this->shortCut;
 }

range/Range/src/action_definition_item.h

@@ -150,7 +150,7 @@ typedef enum _ActionType
 
 class Action;
 
-typedef void (Action::*PointerToMemberFunction)(void);
+typedef void (Action::*PointerToMemberFunction)();
 
 class ActionDefinitionItem
 {
@@ -179,7 +179,7 @@ class ActionDefinitionItem
                              const QString &desc = QString(),
                              const QString &shortCut = QString(),
                              const QString &icon = QString(),
-                             PointerToMemberFunction slot = 0);
+                             PointerToMemberFunction slot = nullptr);
 
         //! Copy constructor.
         ActionDefinitionItem(const ActionDefinitionItem &actionDefinitionItem);
@@ -191,13 +191,13 @@ class ActionDefinitionItem
         ActionDefinitionItem &operator =(const ActionDefinitionItem &actionDefinitionItem);
 
         //! Return action type.
-        ActionType getType(void) const;
+        ActionType getType() const;
 
         //! Return action group type.
-        ActionGroupType getGroupType(void) const;
+        ActionGroupType getGroupType() const;
 
         //! Return const reference to shortcut.
-        const QString &getShortcut(void) const;
+        const QString &getShortcut() const;
 
         //! Return action group name.
         static QString getGroupName(ActionGroupType groupType);

range/Range/src/bc_manager_tree.cpp

@@ -23,8 +23,8 @@ typedef enum _BoundaryConditionTreeColumn
     BC_TREE_N_COLUMNS
 } BoundaryConditionTreeColumn;
 
-BCManagerTree::BCManagerTree(QObject *parent) :
-    QTreeWidget((QWidget*)parent),
+BCManagerTree::BCManagerTree(QWidget *parent) :
+    QTreeWidget(parent),
     doNotPopulate(false)
 {
     this->setSelectionMode(QAbstractItemView::SingleSelection);

range/Range/src/bc_manager_tree.h

@@ -33,7 +33,7 @@ class BCManagerTree : public QTreeWidget
     public:
 
         //! Constructor.
-        explicit BCManagerTree(QObject *parent = nullptr);
+        explicit BCManagerTree(QWidget *parent = nullptr);
 
     protected:
 

range/Range/src/draw_engine_circle.cpp

@@ -49,7 +49,7 @@ DrawEngineCircle::DrawEngineCircle(QObject *parent) :
     this->updateModel();
 }
 
-RModelRaw DrawEngineCircle::generate(void) const
+RModelRaw DrawEngineCircle::generate() const
 {
     RModelRaw modelRaw;
 

range/Range/src/draw_engine_circle.h

@@ -26,7 +26,7 @@ class DrawEngineCircle : public DrawEngineObject
     protected:
 
         //! Generate RAW model from input parameters.
-        virtual RModelRaw generate(void) const;
+        virtual RModelRaw generate() const;
 
 };
 

range/Range/src/draw_engine_cylinder.cpp

@@ -60,7 +60,7 @@ DrawEngineCylinder::DrawEngineCylinder(QObject *parent) :
     this->updateModel();
 }
 
-RModelRaw DrawEngineCylinder::generate(void) const
+RModelRaw DrawEngineCylinder::generate() const
 {
     RModelRaw modelRaw;
 

range/Range/src/draw_engine_cylinder.h

@@ -26,7 +26,7 @@ class DrawEngineCylinder : public DrawEngineObject
     protected:
 
         //! Generate RAW model from input parameters.
-        virtual RModelRaw generate(void) const;
+        virtual RModelRaw generate() const;
 
 };