Fixed potential race condition

RaphiMC · RaphiMC · commit a71dd4f9d5bd · 2024-09-29T13:11:41.000+02:00
diff --git a/src/main/java/net/raphimc/noteblocktool/audio/soundsystem/impl/MultithreadedJavaxSoundSystem.java b/src/main/java/net/raphimc/noteblocktool/audio/soundsystem/impl/MultithreadedJavaxSoundSystem.java
@@ -102,8 +102,8 @@ public synchronized String getStatusLine() {
 
     @Override
     protected int[] render() {
-        this.soundsToRender.addAll(this.playingSounds);
         this.syncLock.set(this.playingSounds.size());
+        this.soundsToRender.addAll(this.playingSounds);
         while (this.syncLock.get() != 0 && !Thread.currentThread().isInterrupted()) {
             // Wait for all sounds to be rendered and merged
         }

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,8 @@ public synchronized String getStatusLine() {`
`102`	`102`
`103`	`103`	`@Override`
`104`	`104`	`protected int[] render() {`
`105`		`- this.soundsToRender.addAll(this.playingSounds);`
`106`	`105`	`this.syncLock.set(this.playingSounds.size());`
	`106`	`+ this.soundsToRender.addAll(this.playingSounds);`
`107`	`107`	`while (this.syncLock.get() != 0 && !Thread.currentThread().isInterrupted()) {`
`108`	`108`	`// Wait for all sounds to be rendered and merged`
`109`	`109`	`}`