Skip to content

Commit f07ee07

Browse files
committed
fix: Fix write() callback invoking IOException objects
Fixes #39
1 parent 20d623b commit f07ee07

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

android/src/main/java/com/asterinet/react/tcpsocket/TcpSocketModule.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ protected void doInBackgroundGuarded(Void... params) {
9595
@SuppressLint("StaticFieldLeak")
9696
@SuppressWarnings("unused")
9797
@ReactMethod
98-
public void write(final Integer cId, final String base64String, final Callback callback) {
98+
public void write(@NonNull final Integer cId, @NonNull final String base64String, @Nullable final Callback callback) {
9999
new GuardedAsyncTask<Void, Void>(mReactContext.getExceptionHandler()) {
100100
@Override
101101
protected void doInBackgroundGuarded(Void... params) {
@@ -105,14 +105,14 @@ protected void doInBackgroundGuarded(Void... params) {
105105
}
106106
try {
107107
socketClient.write(Base64.decode(base64String, Base64.NO_WRAP));
108+
if (callback != null) {
109+
callback.invoke();
110+
}
108111
} catch (IOException e) {
109112
if (callback != null) {
110-
callback.invoke(e);
111-
return;
113+
callback.invoke(e.toString());
112114
}
113-
}
114-
if (callback != null) {
115-
callback.invoke();
115+
onError(cId, e.toString());
116116
}
117117
}
118118
}.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);

0 commit comments

Comments
 (0)