Locales not found

[sunnyt7]

Hey there,

Thanks for this extension :) I noticed on my site and your demo that the locales file isn't loading properly:

GET https://unpkg.com/@raruto/leaflet-gesture-handling@1.4.3/dist/locales/en-CA.js
[HTTP/2 404 Not Found 145ms]

Any chance this could get fixed?

Thanks!

[Raruto]

Hi sunny7t,

this is just a warning inside the browser console, however this file is used as a fallback: leaflet-gesture-handling/src/locales/en.js

Here you can find the inclusion logic related to that file:

leaflet-gesture-handling/src/index.js

Lines 162 to 182 in f31da5e

	_getLanguageContent: function(lang) {
	//Determine user language (eg. fr or en-US)
	lang = lang || this._getUserLanguage() || "en";
	var resolve, promise = new Promise(_resolve => { resolve = _resolve });
	var consume = (m) => {
	var content = m.default || {};
	//Check if they're on a mac for displaying appropriate command control (⌘ instead of Ctrl)
	content.scroll = this._isMacUser() ? content.scrollMac : content.scroll
	resolve(content);
	};
	//Lookup the appropriate language content
	import(baseURL + './locales/' + lang + '.js').then(consume)
	//If no result, try searching by the first part only (eg. en-US, just use en).
	.catch((e) => import(baseURL + './locales/' + lang.split("-")[0] + '.js').then(consume)
	// If still nothing, default to English.
	.catch((e) => Promise.resolve({default:defaultLocale}).then(consume))
	);
	return promise;
	},

If it bothers you, you can propose a pull that improves the control logic or that also makes your locale available to everyone.

Have a nice day,
Raruto

[brunob]

Maybe this can be handled with a variable containing the list of available locales in order to prevent making a 404 request ?

[Raruto]

Honestly, I don't manage sites so large that they require so many translations.

I still think this is still the simplest solution (ie. localize this plugin as you would for the rest of your site..):

If it bothers you, makes your locale available to everyone.

Alternatively, if you feel in the mood, you can think of setup a catch-all rule (eg. some .htaccess rewrite rules *) on your server for intercepts any requests for missing translations files and fallback from there:

* sample .htaccess rewrite rule

# Intercept Missing Files from Locales Folder and Execute locales.php
RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^locales/(.*)$ locales.php [L]

Don't have Apache? Ask AI! 👉 https://zzzcode.ai/code-converter

👋 Raruto

[Raruto]

Maybe this can be handled with a variable containing the list of available locales in order to prevent making a 404 request ?

BTW, you can always setup your preferred "locale", before initializing the map:

gestureHandlingOptions: {
  locale: getUserLang('en'), // your custom function to set user language (or fallback to 'en').
}