Skip to content

Commit d485dc6

Browse files
committed
Re #149 reverted change in widgets naming algorithm
1 parent f89decc commit d485dc6

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

rascal2/ui/view.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -347,19 +347,19 @@ def setup_mdi(self):
347347
return
348348

349349
widgets = {
350-
"Plots": self.plot_widget,
351-
"Project": self.project_widget,
352-
"Terminal": self.terminal_widget,
353-
"Fitting Controls": self.controls_widget,
350+
"plots": self.plot_widget,
351+
"project": self.project_widget,
352+
"terminal": self.terminal_widget,
353+
"fitting controls": self.controls_widget,
354354
}
355355
self.setup_mdi_widgets()
356356

357357
for title, widget in reversed(widgets.items()):
358-
widget.setWindowTitle(title)
358+
widget.setWindowTitle(title.title())
359359
window = self.mdi.addSubWindow(
360360
widget, QtCore.Qt.WindowType.WindowMinMaxButtonsHint | QtCore.Qt.WindowType.WindowTitleHint
361361
)
362-
window.setWindowTitle(title)
362+
window.setWindowTitle(title.title())
363363

364364
self.reset_mdi_layout()
365365
self.startup_dlg = self.takeCentralWidget()
@@ -384,7 +384,7 @@ def reset_mdi_layout(self):
384384
else:
385385
for window in self.mdi.subWindowList():
386386
# get corresponding MDIGeometries entry for the widget
387-
widget_name = window.windowTitle().replace(" ", "")
387+
widget_name = window.windowTitle().lower().split(" ")[-1]
388388
x, y, width, height, minimized = getattr(self.settings.mdi_defaults, widget_name)
389389
if minimized:
390390
window.showMinimized()
@@ -397,7 +397,7 @@ def save_mdi_layout(self):
397397
geoms = {}
398398
for window in self.mdi.subWindowList():
399399
# get corresponding MDIGeometries entry for the widget
400-
widget_name = window.windowTitle().replace(" ", "")
400+
widget_name = window.windowTitle().lower().split(" ")[-1]
401401
geom = window.geometry()
402402
geoms[widget_name] = (geom.x(), geom.y(), geom.width(), geom.height(), window.isMinimized())
403403

tests/ui/test_view.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,12 @@ def test_reset_mdi(self, mock1, mock2, mock3, test_view, geometry):
6464
test_view.settings = Settings()
6565
test_view.setup_mdi()
6666
test_view.settings.mdi_defaults = MDIGeometries(
67-
Plots=geometry[0],
68-
Project=geometry[1],
69-
Terminal=geometry[2],
70-
FittingControls=geometry[3],
71-
SlidersView=geometry[4],
67+
plots=geometry[0], project=geometry[1], terminal=geometry[2], controls=geometry[3]
7268
)
7369
test_view.reset_mdi_layout()
7470
for window in test_view.mdi.subWindowList():
7571
# get corresponding MDIGeometries entry for the widget
76-
widget_name = window.windowTitle().replace(" ", "")
72+
widget_name = window.windowTitle().lower().split(" ")[-1]
7773
w_geom = window.geometry()
7874
assert getattr(test_view.settings.mdi_defaults, widget_name) == (
7975
w_geom.x(),
@@ -90,7 +86,7 @@ def test_set_mdi(self, mock1, mock2, mock3, test_view, geometry):
9086
widgets_in_order = []
9187

9288
for i, window in enumerate(test_view.mdi.subWindowList()):
93-
widgets_in_order.append(window.windowTitle().replace(" ", ""))
89+
widgets_in_order.append(window.windowTitle().lower().split(" ")[-1])
9490
window.setGeometry(*geometry[i][0:4])
9591
if geometry[i][4] is True:
9692
window.showMinimized()

0 commit comments

Comments
 (0)