Addresses review comments

Author: StephenNneji

rascal2/ui/presenter.py

@@ -172,7 +172,7 @@ def interrupt_terminal(self):
 
     def quick_run(self, project=None):
         """Run rat calculation with calculate procedure on the given project.
-        The main project is used if no project is provided.
+        The project in the MainWindowModel is used if no project is provided.
 
         Parameters
         ----------

rascal2/widgets/project/project.py

@@ -250,6 +250,8 @@ def create_edit_view(self) -> QtWidgets.QWidget:
     def show_slider_view(self):
         """Create slider view and make it visible."""
         if self.stacked_widget.count() == 3:
+            # 3 widgets means slider view already exist
+            # (with project view and edit view) so delete before replacing with new one
             old_slider_widget = self.stacked_widget.widget(2)
             self.stacked_widget.removeWidget(old_slider_widget)
             old_slider_widget.deleteLater()
@@ -258,8 +260,9 @@ def show_slider_view(self):
         self.stacked_widget.setCurrentIndex(2)
 
     def update_slider_view(self):
-        """Update the draft project if it changes."""
+        """Update the slider view if the project changes when it is opened."""
         if self.stacked_widget.currentIndex() == 2:
+            # slider view is the 3rd widget in the layout
             widget = self.stacked_widget.widget(2)
             widget.draft_project = create_draft_project(self.parent_model.project)
             widget.initialize()

rascal2/widgets/project/slider_view.py

@@ -244,10 +244,10 @@ def _slider_value_to_param_value(self, value: int) -> float:
         """
 
         value_step = (self.param.max - self.param.min) / self._slider.maximum()
-        value = self.param.min + value * value_step
-        if value > self.param.max:  # This should not happen but do occur due to round-off errors
-            value = self.param.max
-        return value
+        param_value = self.param.min + value * value_step
+        if param_value > self.param.max:  # This should not happen but do occur due to round-off errors
+            param_value = self.param.max
+        return param_value
 
     def _update_value(self, value: int):
         """Update parameter value and plot when slider value is changed.

tests/widgets/project/test_slider_view.py

@@ -49,7 +49,7 @@ def draft_project():
         ]
     )
 
-    yield draft
+    return draft
 
 
 def test_no_sliders_creation():