Skip to content

Commit 752389b

Browse files
authored
Merge pull request #14 from RasmussenLab/slim_default_installation
🎨 ➖ remove umap-learn. also remove lifelines dependency for default pkg
2 parents 90b57d5 + d072239 commit 752389b

File tree

14 files changed

+39
-30
lines changed

14 files changed

+39
-30
lines changed

.github/workflows/packaging.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ jobs:
4343
strategy:
4444
matrix:
4545
python:
46+
- version: "3.12"
47+
toxenv: "py312"
4648
- version: "3.11"
4749
toxenv: "py311"
4850
- version: "3.10"
4951
toxenv: "py310"
5052
- version: "3.9"
5153
toxenv: "py39"
52-
- version: "3.8"
53-
toxenv: "py38"
5454
steps:
5555
- uses: actions/checkout@v4
5656

@@ -139,4 +139,4 @@ jobs:
139139
- uses: pypa/gh-action-pypi-publish@release/v1
140140
with:
141141
user: __token__
142-
password: ${{ secrets.PYPI_API_TOKEN }}
142+
password: ${{ secrets.PYPI_API_TOKEN }}

.readthedocs.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,4 @@ python:
3232
path: .
3333
extra_requirements:
3434
- docs
35+
- all

docs/tutorial/explorative_analysis.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
},
2323
"outputs": [],
2424
"source": [
25-
"%pip install njab openpyxl"
25+
"%pip install 'njab[all]' openpyxl"
2626
]
2727
},
2828
{

docs/tutorial/explorative_analysis.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
# First install the dependencies:
2121

2222
# %% tags=["hide-output"]
23-
# %pip install njab openpyxl
23+
# %pip install 'njab[all]' openpyxl
2424

2525
# %% tags=["hide-cell"]
2626
from functools import partial

docs/tutorial/log_reg.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"source": [
2828
"# Setup colab installation\n",
2929
"# You need to restart the runtime after running this cell\n",
30-
"%pip install njab heatmapz openpyxl plotly"
30+
"%pip install njab heatmapz openpyxl plotly umap-learn"
3131
]
3232
},
3333
{

docs/tutorial/log_reg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
# %% tags=["hide-output"]
2626
# Setup colab installation
2727
# You need to restart the runtime after running this cell
28-
# %pip install njab heatmapz openpyxl plotly
28+
# %pip install njab heatmapz openpyxl plotly umap-learn
2929

3030
# %% tags=["hide-input"]
3131
import itertools

pyproject.toml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name = "njab"
33
authors = [{ name = "Henry Webel", email = "henry.webel@cpr.ku.dk" }]
44
description = "not Just Another Biomarker"
55
readme = "README.md"
6-
requires-python = ">=3.8"
6+
requires-python = ">=3.9"
77
keywords = ["bioinformatics", "biomarker"]
88
license = { file = "LICENSE" }
99
classifiers = [
@@ -15,12 +15,10 @@ classifiers = [
1515
]
1616
dependencies = [
1717
"omegaconf",
18-
"lifelines",
1918
"numpy",
2019
"pandas",
2120
"scikit-learn",
2221
"statsmodels",
23-
"umap-learn",
2422
"matplotlib",
2523
"mrmr_selection",
2624
"pingouin",
@@ -29,6 +27,9 @@ dependencies = [
2927
dynamic = ["version"]
3028

3129
[project.optional-dependencies]
30+
all = [
31+
"lifelines",
32+
]
3233
docs = [
3334
"sphinx",
3435
"sphinx-book-theme",

setup.cfg

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ based_on_style = pep8
66
######################
77

88
[mypy]
9-
python_version = 3.8
9+
python_version = 3.10
1010
warn_unused_configs = True
1111
show_error_context = True
1212
pretty = True
@@ -39,7 +39,7 @@ source =
3939
#########################
4040

4141
[tox:tox]
42-
envlist = py38,py39,py310,py311
42+
envlist = py39,py310,py311,py312
4343
isolated_build = True
4444

4545
[testenv]

src/njab/io/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from __future__ import annotations
21
import pathlib
32

43

src/njab/plotting/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
"""Matplotlib functionality for custom plots."""
22

3-
import numpy as np
4-
import pandas as pd
5-
import matplotlib
63
import logging
74
import pathlib
85
from typing import Iterable
6+
7+
import matplotlib
98
import matplotlib.pyplot as plt
9+
import numpy as np
10+
import pandas as pd
1011

1112
from njab.plotting.lifelines import plot_lifelines
12-
from njab.plotting.km import compare_km_curves
1313

14-
__all__ = ['plot_lifelines', 'compare_km_curves']
14+
__all__ = ['plot_lifelines']
1515

1616
plt.rcParams['figure.figsize'] = [4.0, 3.0]
1717
plt.rcParams['pdf.fonttype'] = 42

0 commit comments

Comments
 (0)