chore: lint for floating promises

Fix missing awaits in the tests.
Acknowledge a couple of intentionally missing awaits in src.

Needed tsconfig information so I've added the project setting - see
https://typescript-eslint.io/blog/parser-options-project-true/#introducing-true

Author: microbit-matt-hillsdon

eslint.config.js

@@ -144,6 +144,8 @@ module.exports = [
         ecmaVersion: 6,
         sourceType: 'module',
         warnOnUnsupportedTypeScriptVersion: true,
+        project: true,
+        tsconfigRootDir: __dirname,
       },
     },
     settings: {
@@ -239,6 +241,7 @@ module.exports = [
 
       '@typescript-eslint/no-empty-interface': 'error',
       '@typescript-eslint/no-explicit-any': 'warn',
+      '@typescript-eslint/no-floating-promises': 'error',
       '@typescript-eslint/no-inferrable-types': 'error',
       '@typescript-eslint/no-misused-new': 'error',
       '@typescript-eslint/no-namespace': 'error',

src/actions/enter.ts

@@ -159,7 +159,7 @@ export class EnterAction {
       // opening a bubble of some sort. We then need to wait for the bubble to
       // appear before attempting to navigate into it.
       curNode.onClick();
-      renderManagement.finishQueuedRenders().then(() => {
+      void renderManagement.finishQueuedRenders().then(() => {
         cursor?.in();
       });
       return true;

src/actions/exit.ts

@@ -53,7 +53,7 @@ export class ExitAction {
                     icon.getBubble()?.getWorkspace() === workspace,
                 );
               if (parent) {
-                parent.setBubbleVisible(false);
+                void parent.setBubbleVisible(false);
                 getFocusManager().focusNode(parent);
                 return true;
               }

test/webdriverio/test/keyboard_mode_test.ts

@@ -86,7 +86,7 @@ suite(
 
       chai.assert.isFalse(await isKeyboardNavigating(this.browser));
 
-      this.browser.execute(() => {
+      await this.browser.execute(() => {
         Blockly.keyboardNavigationController.setIsActive(true);
       });
 
@@ -106,7 +106,7 @@ suite(
 
       chai.assert.isFalse(await isKeyboardNavigating(this.browser));
 
-      this.browser.execute(() => {
+      await this.browser.execute(() => {
         Blockly.keyboardNavigationController.setIsActive(true);
       });
 
@@ -126,7 +126,7 @@ suite(
 
       await this.browser.pause(PAUSE_TIME);
       // Right click a block
-      clickBlock(this.browser, 'controls_if_1', {button: 'right'});
+      await clickBlock(this.browser, 'controls_if_1', {button: 'right'});
       await this.browser.pause(PAUSE_TIME);
 
       chai.assert.isFalse(await isKeyboardNavigating(this.browser));

test/webdriverio/test/scroll_test.ts

@@ -24,7 +24,7 @@ suite('Scrolling into view', function () {
   setup(async function () {
     this.browser = await testSetup(testFileLocations.BASE);
     // Predictable small window size for scrolling.
-    this.browser.setWindowSize(800, 600);
+    await this.browser.setWindowSize(800, 600);
     await this.browser.pause(PAUSE_TIME);
   });
 

test/webdriverio/test/test_setup.ts

@@ -418,10 +418,10 @@ export async function tabNavigateToWorkspace(
   hasFlyout = true,
 ) {
   // Navigate past the initial pre-injection focusable div element.
-  tabNavigateForward(browser);
-  if (hasToolbox) tabNavigateForward(browser);
-  if (hasFlyout) tabNavigateForward(browser);
-  tabNavigateForward(browser); // Tab to the workspace itself.
+  await tabNavigateForward(browser);
+  if (hasToolbox) await tabNavigateForward(browser);
+  if (hasFlyout) await tabNavigateForward(browser);
+  await tabNavigateForward(browser); // Tab to the workspace itself.
 }
 
 /**

tsconfig.json

@@ -13,5 +13,5 @@
   // NOTE: `test/**/*` is automatically included in `blockly-scripts start`.
   // Only src matters for production builds.
   "include": ["./src", "./test"],
-  "exclude": ["./test/webdriverio/"]
+  "exclude": ["./test/webdriverio/test"]
 }