move mode focus issues

[maribethb]

Check for duplicates

• I have searched for similar issues before opening a new one.

Description

Move mode has some unexpected issues around focus or focus visualization. See repro steps.

Possibly related but possibly not, RaspberryPiFoundation/blockly#9112. That one is the more serious of the issues so it should be looked at first

Reproduction steps

Workspace visualization

2. Focus a block
3. Press M for move mode
4. Notice that the workspace no longer has the blue focus ring.
5. Enter to commit move.
6. Notice the workspace once again has the blue focus ring.

I don't think it should disappear while move mode is active. This could just be a css issue.

When field editors are open

This one relies on RaspberryPiFoundation/blockly#9110 and #568 being in

1. Focus a field with a dropdown editor
2. Press enter to open the editor
3. Press M for move mode
4. Move mode isn't activated, because the precondition fails now, this is the correct behavior
5. However, the passive focus indicator on the field that has its editor open has disappeared.

Stack trace

Screenshots

No response

Browsers

No response

[microbit-matt-hillsdon]

I don't think it should disappear while move mode is active. This could just be a css issue.

Agreed. I think we can add this to the workspace focus ring selectors.

.blocklyKeyboardNavigation .blocklySvg:has(~ .blocklyBlockDragSurface .blocklyActiveFocus) .blocklyWorkspaceFocusRing,