chore: fix lint errors and run lint in CI #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test would be nice too but to do separately
microbit-matt-hillsdon
requested review from
RoboErikG
and removed request for
a team
Now `setCurNode` can take null we don't need them.
RoboErikG
reviewed
Mar 28, 2025
RoboErikG
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #345
This adds ignores for the non-null checks that relate to createXXXNode. It wasn't as bad as I expected as
setCurNodepermits null now. Raised RaspberryPiFoundation/blockly#8827 in case there's interest in revisiting the signature or behaviour here.It might also be nice to explore converting the tests to TypeScript before we make more of them. It didn't seem too hard to fix the current lint issues there so I've left lint enabled for them.