feat: monkeypatch the block's drag strategy during keyboard drags #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
requested review from
RoboErikG and
maribethb
and removed request for
a team and
RoboErikG
RoboErikG
approved these changes
Apr 2, 2025
Contributor
RoboErikG
left a comment
RoboErikG
left a comment
There was a problem hiding this comment.
Looks fine, just a question on MoveInfo types which isn't directly part of this change.
cpcallen
reviewed
Jun 6, 2025
| * The block's base drag strategy, which will be overridden during | ||
| * keyboard drags and reset at the end of the drag. | ||
| */ | ||
| private oldDragStrategy: IDragStrategy | null = null; |
Collaborator
There was a problem hiding this comment.
This should be on MoveInfo because Mover can handle multiple simultaneous moves on different workspaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373.
Adds a drag strategy class and the appropriate patching and unpatching at beginning and end of drag.
The new class extends core's
BlockDragStrategy. Populating it with useful functions is tracked in #364.Part of #363
Tested by:
Doing keyboard drags that end in an Esc
Doing keyboard drags that end in an Enter
Doing mouse drags after the fact to confirm that mouse dragging still works