fix: heuristic insert for statment block when value block is selected #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We're currently working to improve this PR, so converting to draft for now. |
Contributor
Author
|
Closing in favour of #432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #418. I'm not at all convinced that this is the right approach as the first warning message we get is
This block can not be inserted at the marked locationfrom inside theinsertBlockmethod. However, the behaviour demonstrated here is what I think we're after.Please feel free to close this in favour of a better approach or more reasoned approach.
Demo: https://insert-at-value.blockly-keyboard-experimentation.pages.dev/