Skip to content

fix: don't set cursor to disposed passiveFocusNode #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenHenning merged 1 commit into from
Apr 14, 2025
Merged

fix: don't set cursor to disposed passiveFocusNode #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,9 +403,11 @@ export class Navigation {
if (cursor) {
const passiveFocusNode = this.passiveFocusIndicator.getCurNode();
this.passiveFocusIndicator.hide();
// If there's a gesture then it will either set the node or be a click
const disposed = passiveFocusNode?.getSourceBlock()?.disposed;
// If there's a gesture then it will either set the node if it has not
// been disposed (which can happen when blocks are reloaded) or be a click
// that should not set one.
if (!Blockly.Gesture.inProgress() && passiveFocusNode) {
if (!Blockly.Gesture.inProgress() && passiveFocusNode && !disposed) {
cursor.setCurNode(passiveFocusNode);
}
}
Expand Down
Loading