feat: auto confirm a move on subsequent action #437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We've now merged a version of this into our user testing branch in our fork of the project that ignores all non-move-related actions while a move is in progress instead of finishing the move and running the non-move-related action following discussion yesterday. It's still not clear the API for this should look like in core. Perhaps both the workspace and the actions have a 'normal' mode and 'move' mode where only the actions with a mode that matches that of the workspace are allowed through? |
Contributor
Author
|
See also the discussion from this comment re clicking outside of the workspace. |
Contributor
Author
|
What do folks think re this behaviour? @rachel-fenichel @maribethb |
1 task
Closed
Contributor
Author
|
Closing in favour of #560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack to get a behaviour we like like. It's not clear what the right API for this would be.
For discussion later today.
Fixes #434 context menu during move as well as similar bugs such as clean up durning move, cut during move, likely others.
Nice API could be a workspace-wide precondition that applies to all actions that was invoked with the name of the intended shortcut.
Demo: https://auto-confirm-move.blockly-keyboard-experimentation.pages.dev/