Skip to content

chore: Improve safety of flyout change listener. #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 2 commits into from
Apr 25, 2025
Merged

chore: Improve safety of flyout change listener. #469

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7456ffb
chore: Improve safety of flyout change listener.
gonfunko Apr 25, 2025
f750cc8
chore: Use null instead of undefined.
gonfunko Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,10 @@ export class Navigation {
if (!e.workspaceId) {
return;
}
const flyoutWorkspace = Blockly.Workspace.getById(
e.workspaceId,
) as Blockly.WorkspaceSvg;
const mainWorkspace = flyoutWorkspace.targetWorkspace;
const flyoutWorkspace = Blockly.Workspace.getById(e.workspaceId) as
| Blockly.WorkspaceSvg
| undefined;
const mainWorkspace = flyoutWorkspace?.targetWorkspace;
if (!mainWorkspace) {
return;
}
Expand Down
Loading