feat: Add a visual indicator to blocks in move mode. #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
requested review from
RoboErikG and
rachel-fenichel
and removed request for
a team and
RoboErikG
rachel-fenichel
approved these changes
Apr 25, 2025
Collaborator
rachel-fenichel
left a comment
rachel-fenichel
left a comment
There was a problem hiding this comment.
Approving. One of the build failures in CI is on a line that this PR doesn't change, which makes me suspect issues with the simultaneous changes in core and here. Aaron verified that it was able to build and run locally.
@maribethb FYI for when you get back, in case you have opinions about this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #465 by adding a new icon and associated bubble that display a four-way-arrow move indicator attached to the corner of blocks while they are in move mode.