Skip to content

fix: remove unneeded ts-expect-error directives #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rachel-fenichel merged 1 commit into from
Apr 28, 2025
Merged

fix: remove unneeded ts-expect-error directives #473

rachel-fenichel merged 1 commit into from
Apr 28, 2025

Conversation

@rachel-fenichel
Copy link
Collaborator

@rachel-fenichel rachel-fenichel commented Apr 28, 2025

Resolves compiler errors.

block is still private on the base class; the only reason the expect-error directives are unneeded is because there's an expect-error at the top level of the class that blocks issues with redeclaring a private property.

Followup on #472

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner April 28, 2025 21:08
@rachel-fenichel rachel-fenichel requested review from RoboErikG and cpcallen and removed request for a team April 28, 2025 21:08
@rachel-fenichel rachel-fenichel merged commit e30d12c into RaspberryPiFoundation:main Apr 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpcallen cpcallen Awaiting requested review from cpcallen cpcallen was automatically assigned from google/blockly-eng

1 more reviewer

@RoboErikG RoboErikG RoboErikG approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RoboErikG RoboErikG

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rachel-fenichel @RoboErikG