chore: Implement field navigation tests. #486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
requested review from
RoboErikG
and removed request for
BenHenning
Collaborator
|
@RoboErikG please rebase this PR once sufficient changes are made in core and over here to make it build, fix lint/format, and then review the actual test contents and merge if good. Thanks John for writing these tests! |
Contributor
|
Replaced by #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements several unit tests described in https://docs.google.com/document/d/1pIIX5sKEG9f_NcWDIQJJEOMM7w7pQUf8eJoT3lrAElQ involving navigating with the arrow keys when starting from a field or inline input.
I ran these tests using old code for both core blockly and keyboard experimentation. I built against a slightly older commit from core blockly rc/v12.0.0, namely this one RaspberryPiFoundation/blockly@dee27b9 since the most recent commit seems unstable at the moment. I also did not update to the latest commit of keyboard experimentation before writing these tests, namely I remained at: c90aae9
Updating the code in either repo introduces compilation errors that I'm not sure how to address yet.
The last test I left commented out because it fails even though I wrote it with the expectation that it would succeed. It seems that the curly quote icons in a text block count as selection stops when pressing the right arrow key, even though they are not interactive. If the quotes are fixed, then the test can be uncommented to verify that the right arrow key navigates past them.