fix: Fix when the context menu is allowed to open #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Assigning @BenHenning to review because I don't understand the workspace state changes. |
Collaborator
|
Also fixes (?) #276 |
Contributor
Author
|
It partly fixes 276 by allowing the context menu to open in the flyout, but making copy/paste work correctly requires fixing some things in core or undoing Maribeth's change to depend on the core callbacks. |
1 task
Contributor
Author
BenHenning
reviewed
May 27, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @RoboErikG. I think the solution makes sense. Is it possible add tests for these cases?
BenHenning
approved these changes
May 28, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @RoboErikG! Approving to unblock, but I did have some thoughts on the tests. Feel free to re-add me if you'd like another review pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434
Fixes #276
#546 is partly fixed by this change but may still need some work for shortcuts other than menu opening.
This fixes the precondition checks for showing the action menu and also enables the action menu to be shown in the flyout so that it's consistent with right click.