Skip to content

Conversation

@maribethb
Copy link
Collaborator

@maribethb maribethb commented May 28, 2025

Works on RaspberryPiFoundation/blockly#8852

  • Removes the input mode tracking from the experiment in favor of the tracker in core
  • Sets keyboard mode to true in certain cases:
    • arrow key navigation
    • T for toolbox
    • M for move mode
    • W for workspace cursor
    • X to disconnect
    • Edit block context menu item (this one is potentially debatable since it only hits from the context menu)

See matching core PR in RaspberryPiFoundation/blockly#8924

@maribethb maribethb requested a review from a team as a code owner May 28, 2025 17:42
@maribethb maribethb requested review from RoboErikG and removed request for a team May 28, 2025 17:42
Copy link
Contributor

@RoboErikG RoboErikG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the core change is in and tests pass.

@maribethb
Copy link
Collaborator Author

Added tests

@rachel-fenichel rachel-fenichel self-requested a review May 29, 2025 19:15
@rachel-fenichel rachel-fenichel self-assigned this May 29, 2025
Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM.

@maribethb maribethb merged commit 656624a into RaspberryPiFoundation:main May 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants