onShortcut monkey-patch #560
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-matt-hillsdon
requested review from
maribethb
and removed request for
a team
This was referenced May 29, 2025
Contributor
Author
Collaborator
|
@gonfunko is working on a change for this that doesn't involve a monkeypatch and should be ready today. |
Collaborator
|
Aaron's change is only for the first issue, not the second. I'm working on the second issue though. Going to have to go with the precondition approach because I think not firing them at all if the widget div is open would be a breaking change. |
Collaborator
|
We shouldn't need this due to this behavior being implemented by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible temporary, plugin-only fix for #437 and RaspberryPiFoundation/blockly#9101
Needs discussion before merge but at least lets you play with behaviour.