Skip to content

chore: lint for floating promises #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maribethb merged 1 commit into from
Jul 30, 2025
Merged

chore: lint for floating promises #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,4 +259,17 @@ module.exports = [
'@typescript-eslint/no-require-imports': 'error',
},
},
{
files: ['test/webdriverio/test/*.ts'],
languageOptions: {
parserOptions: {
project: true,
tsconfigRootDir: __dirname,
},
},
rules: {
'@typescript-eslint/no-floating-promises': 'error',
'@typescript-eslint/no-misused-promises': 'error',
},
},
];
6 changes: 3 additions & 3 deletions test/webdriverio/test/keyboard_mode_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ suite(

chai.assert.isFalse(await isKeyboardNavigating(this.browser));

this.browser.execute(() => {
await this.browser.execute(() => {
Blockly.keyboardNavigationController.setIsActive(true);
});

Expand All @@ -106,7 +106,7 @@ suite(

chai.assert.isFalse(await isKeyboardNavigating(this.browser));

this.browser.execute(() => {
await this.browser.execute(() => {
Blockly.keyboardNavigationController.setIsActive(true);
});

Expand All @@ -126,7 +126,7 @@ suite(

await this.browser.pause(PAUSE_TIME);
// Right click a block
clickBlock(this.browser, 'controls_if_1', {button: 'right'});
await clickBlock(this.browser, 'controls_if_1', {button: 'right'});
await this.browser.pause(PAUSE_TIME);

chai.assert.isFalse(await isKeyboardNavigating(this.browser));
Expand Down
2 changes: 1 addition & 1 deletion test/webdriverio/test/scroll_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ suite('Scrolling into view', function () {
setup(async function () {
this.browser = await testSetup(testFileLocations.BASE);
// Predictable small window size for scrolling.
this.browser.setWindowSize(800, 600);
await this.browser.setWindowSize(800, 600);
await this.browser.pause(PAUSE_TIME);
});

Expand Down
8 changes: 4 additions & 4 deletions test/webdriverio/test/test_setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,10 +441,10 @@ export async function tabNavigateToWorkspace(
hasFlyout = true,
) {
// Navigate past the initial pre-injection focusable div element.
tabNavigateForward(browser);
if (hasToolbox) tabNavigateForward(browser);
if (hasFlyout) tabNavigateForward(browser);
tabNavigateForward(browser); // Tab to the workspace itself.
await tabNavigateForward(browser);
if (hasToolbox) await tabNavigateForward(browser);
if (hasFlyout) await tabNavigateForward(browser);
await tabNavigateForward(browser); // Tab to the workspace itself.
}

/**
Expand Down
1 change: 0 additions & 1 deletion test/webdriverio/test/workspace_comment_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import * as chai from 'chai';
import * as Blockly from 'blockly';
import {
contextMenuExists,
focusOnBlock,
getCurrentFocusNodeId,
getFocusedBlockType,
Expand Down
Loading