fix: use normal shortcut modifier order and prefer shorter shortcuts #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behaviour changes: - Sort modifiers so we don't say Shift+Cmd+Z for redo on Mac - Ctrl+Y is the preferred redo shortcut on Windows and not all apps support the more cross-platform Ctrl+Shift+Z Implementation change: - Map to user-facing key names last to keep earlier modifier logic using the shortcut registry representation of the modifiers. This the same point we do translations of modifiers in the equivalent code in MakeCode. Fixes RaspberryPiFoundation#647
microbit-matt-hillsdon
requested review from
gonfunko
and removed request for
a team
gonfunko
approved these changes
Jul 28, 2025
Contributor
Author
|
Just a reminder that you need to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaviour changes:
Implementation change:
This PR is equivalent to changes we've had in MakeCode for a while now.
Fixes #647
Demo: https://shortcut-formatting-tweaks.blockly-keyboard-experimentation.pages.dev/