fix: Remove null checks for cursor. #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
approved these changes
Jul 16, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
LGTM, thanks @gonfunko!
Just had one additional clean-up suggestion.
BenHenning
reviewed
Jul 16, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Ah, I didn't realize my comment hadn't posted since the line isn't part of the diff.
I suggest removing the EsLint failure in edit.ts for removing the LineCursor import since there are already cursor clean-ups happening here, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #471 by removing checks/conditions for a null cursor. The cursor was made always non-null in RaspberryPiFoundation/blockly#9210, so these are now unnecessary.