fix: Remove side effects from keyboard-experiment. #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
approved these changes
Jul 15, 2025
Collaborator
|
Should this not have been marked as a breaking change? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #327 by removing side effects associated with loading (but not instantiating) the keyboard experiment. #183 has been closed, the gesture monkeypatch is no more,
LineCursoris handled in core, which leaves the toolbox monkeypatch andFlyoutCursorregistration. The toolbox monkeypatch has been removed in favor of a toolbox subclass with explicit registration, and the automatic registration for theFlyoutCursorhas been replaced with explicit registration as well. AFAICT there are no other remaining side effects.