diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 41f96b40..8391cf1a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -6,14 +6,14 @@ on: pull_request: push: branches: - - main + - add-screen-reader-support-experimental permissions: contents: read jobs: build_tip_of_tree_v12: - name: Build test (against tip-of-tree core develop) + name: Build test (against add-screen-reader-support-experimental core develop) runs-on: ubuntu-latest steps: - name: Checkout experimentation plugin @@ -25,7 +25,7 @@ jobs: uses: actions/checkout@v4 with: repository: 'google/blockly' - ref: 'develop' + ref: 'add-screen-reader-support-experimental' path: core-blockly - name: Use Node.js 20.x @@ -42,7 +42,7 @@ jobs: npm install cd .. - - name: Link latest Blockly develop + - name: Link latest Blockly add-screen-reader-support-experimental run: | cd core-blockly npm run package @@ -57,26 +57,6 @@ jobs: cd main npm run build - build: - name: Build test (against pinned v12) - # Don't run pinned version checks for PRs. - if: ${{ !github.base_ref }} - runs-on: ubuntu-latest - steps: - - name: Checkout experimentation plugin - uses: actions/checkout@v4 - - - name: Use Node.js 20.x - uses: actions/setup-node@v4 - with: - node-version: 20.x - - - name: NPM install - run: npm install - - - name: Verify build - run: npm run build - lint: name: Eslint check timeout-minutes: 5 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6419b501..f52a5bff 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,14 +7,14 @@ on: pull_request: push: branches: - - main + - add-screen-reader-support-experimental permissions: contents: read jobs: - webdriverio_tests_tip_of_tree_v12: - name: WebdriverIO tests (against tip-of-tree core develop) + webdriverio_tests: + name: WebdriverIO tests (against add-screen-reader-support-experimental core develop) timeout-minutes: 10 runs-on: ${{ matrix.os }} @@ -29,11 +29,11 @@ jobs: with: path: main - - name: Checkout core Blockly + - name: Checkout experimentation Blockly uses: actions/checkout@v4 with: repository: 'google/blockly' - ref: 'develop' + ref: 'add-screen-reader-support-experimental' path: core-blockly - name: Use Node.js 20.x @@ -50,7 +50,7 @@ jobs: npm install cd .. - - name: Link latest Blockly develop + - name: Link latest Blockly add-screen-reader-support-experimental run: | cd core-blockly npm run package @@ -64,30 +64,3 @@ jobs: run: | cd main npm run test - - webdriverio_tests: - name: WebdriverIO tests (against pinned v12) - # Don't run pinned version checks for PRs. - if: ${{ !github.base_ref }} - timeout-minutes: 10 - runs-on: ${{ matrix.os }} - - strategy: - fail-fast: false - matrix: - os: [ubuntu-latest, macos-latest] - - steps: - - name: Checkout experimentation plugin - uses: actions/checkout@v4 - - - name: Use Node.js 20.x - uses: actions/setup-node@v4 - with: - node-version: 20.x - - - name: NPM install - run: npm install - - - name: Run tests - run: npm run test diff --git a/src/actions/mover.ts b/src/actions/mover.ts index ebc9b1e4..fc20113e 100644 --- a/src/actions/mover.ts +++ b/src/actions/mover.ts @@ -244,11 +244,9 @@ export class Mover { this.patchDragger(info.dragger as dragging.Dragger, dragStrategy.moveType); // Save the position so we can put the cursor in a reasonable spot. - // @ts-expect-error Access to private property connectionCandidate. const target = dragStrategy.connectionCandidate?.neighbour; // Prevent the strategy connecting the block so we just delete one block. - // @ts-expect-error Access to private property connectionCandidate. dragStrategy.connectionCandidate = null; info.dragger.onDragEnd( diff --git a/src/keyboard_drag_strategy.ts b/src/keyboard_drag_strategy.ts index 09b3bcc2..45b67d11 100644 --- a/src/keyboard_drag_strategy.ts +++ b/src/keyboard_drag_strategy.ts @@ -50,7 +50,6 @@ export class KeyboardDragStrategy extends dragging.BlockDragStrategy { // to the top left of the workspace. // @ts-expect-error block and startLoc are private. this.block.moveDuringDrag(this.startLoc); - // @ts-expect-error connectionCandidate is private. this.connectionCandidate = this.createInitialCandidate(); this.forceShowPreview(); this.block.addIcon(new MoveIcon(this.block)); @@ -62,9 +61,7 @@ export class KeyboardDragStrategy extends dragging.BlockDragStrategy { super.drag(newLoc); // Handle the case when an unconstrained drag found a connection candidate. - // @ts-expect-error connectionCandidate is private. if (this.connectionCandidate) { - // @ts-expect-error connectionCandidate is private. const neighbour = (this.connectionCandidate as ConnectionCandidate) .neighbour; // The next constrained move will resume the search from the current @@ -253,7 +250,6 @@ export class KeyboardDragStrategy extends dragging.BlockDragStrategy { private forceShowPreview() { // @ts-expect-error connectionPreviewer is private const previewer = this.connectionPreviewer; - // @ts-expect-error connectionCandidate is private const candidate = this.connectionCandidate as ConnectionCandidate; if (!candidate || !previewer) return; const block = this.block; diff --git a/test/index.html b/test/index.html index 212d0354..d4cb4378 100644 --- a/test/index.html +++ b/test/index.html @@ -134,6 +134,34 @@ +