test(Mover): Add test for moving statement blocks
#704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove an unnecessary round trip through JSON.stringify + JSON.parse.
Introduce moveStatementTestBlocks and suite 'Statement move tests', for testing movement of statement blocks. Move the existing test for constrained movement following unconstrained movement to the new suite.
Introduce a new helper function, testMove, that encapsulates the work needed to test moving a block through a constrained move, checking candidate connections and final position. Use this helper to reimplement the move left/right test as two separate tests.
Modify getConnectionCandidate to also return the index of candidateConnection.local in the list of connections returned from block.getConnections_(true), so we can check wich connection on the moving block is being used to connect. For the simple mover case this is not very interesting (it's normally index 0, for the previous connection, occasionally index 1 if the moving block will be the new top block in a stack) but this will be more important for tests involving moving more complexly-shaped blocks.
Add a new, E-shaped block with ID complex_mover to moveStatementTestBlocks, and update expected test results for statement move tests.
Note that this test verifies current behaviour which, due to bug RaspberryPiFoundation#702, does not conform to the desired behaviour. There are TODOs to update tests to desired behaviour when bug is fixed.
RoboErikG
approved these changes
Aug 27, 2025
This was referenced Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.stringify+JSON.parsewhen loading tests blocks.Part of #696.