refactor(tests): Refactor move tests to simplify moveTest helper
#706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PAUSE_TIME is set to a value other than 0 the comparison in sendKeyAndWait generates a TS unintentionl comparison error.
Simplify moveTest (and the tests that use it) by assuming that the move always finishes in the same location it started in. We will leave testing various move end scenarios (e.g. healing) for a separate suite of move-finishing tests, akin to existing move start tests.
RoboErikG
reviewed
Aug 28, 2025
Collaborator
Author
|
OK, I had to re-run the flaky test a few too many times for my liking but I believe this is now ready to go, pending review. |
Collaborator
Author
|
Superseded by #710. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tweaks to PR #704 in preparation for adding more move tests:
// @ts-ignoreto suppress an Unintended Comparison error that can occur whenPAUSE_TIMEis set to a value other than0.moveTesthelper: by assuming that the moving block always finishes at the same location it starts, it's possible to considerably simplify the tests that call it.Part of #696.