Skip to content

fix: add instructions on how to register toolbox #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maribethb merged 1 commit into from
Sep 5, 2025
Merged

fix: add instructions on how to register toolbox #715

maribethb merged 1 commit into from
Sep 5, 2025

Conversation

@maribethb
Copy link
Collaborator

@maribethb maribethb commented Sep 5, 2025

Fixes #713

  • Add a static method to KeyboardNavigation class that calls registerNavigationDeferringToolbox. This code wasn't otherwise previously exported from the plugin.
  • Update the README with instructions to use that or to override onKeyDown_ in custom toolbox implementations.

@maribethb maribethb requested a review from a team as a code owner September 5, 2025 18:34
@maribethb maribethb requested review from gonfunko and removed request for a team September 5, 2025 18:34
@maribethb maribethb merged commit 344c1bf into RaspberryPiFoundation:main Sep 5, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gonfunko gonfunko gonfunko approved these changes

Assignees

@gonfunko gonfunko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NavigationDeferringToolbox registration happens outside constructor

2 participants

@maribethb @gonfunko