Skip to content

Conversation

@gonfunko
Copy link
Contributor

@gonfunko gonfunko commented Sep 5, 2025

This PR adds the advanced playground, with its debug options/extra blocks/block persistence across reloads, to the demo/test page available through npm run start.

@gonfunko gonfunko requested a review from a team as a code owner September 5, 2025 19:55
@gonfunko gonfunko requested review from maribethb and removed request for a team September 5, 2025 19:55
Copy link
Collaborator

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's weird that this PR contains already-merged commits but otherwise lgtm.

I do wonder if we should run this by matt since they use this page for internal testing, but we can always revert it if they hate it.

nit: this should be a chore since it isn't a feature that should cause a new minor version of the plugin

@gonfunko gonfunko force-pushed the advanced-playground branch from c486870 to 298e8b9 Compare September 5, 2025 20:41
@gonfunko gonfunko changed the title feat: Add the advanced playground to the demo/test page. chore: Add the advanced playground to the demo/test page. Sep 5, 2025
@gonfunko gonfunko force-pushed the advanced-playground branch from ca89631 to 1242271 Compare September 5, 2025 20:42
@gonfunko
Copy link
Contributor Author

gonfunko commented Sep 5, 2025

Fixed the extra commits and commit type, thanks!

@gonfunko gonfunko merged commit 3ef37bc into main Sep 8, 2025
7 of 8 checks passed
@gonfunko gonfunko deleted the advanced-playground branch September 8, 2025 16:58
@cpcallen cpcallen mentioned this pull request Sep 17, 2025
1 task
cpcallen added a commit to cpcallen/blockly-keyboard-experimentation that referenced this pull request Sep 17, 2025
cpcallen added a commit that referenced this pull request Sep 18, 2025
gonfunko added a commit that referenced this pull request Sep 25, 2025
gonfunko added a commit that referenced this pull request Oct 2, 2025
gonfunko added a commit that referenced this pull request Oct 2, 2025
* fix: Fix the scenario picker with the advanced playground.

* Revert "fix(tests): Fix playground scenario selector by reverting PR #718 (#735)"

This reverts commit f4560fd.

* chore: Update dev-tools.

* chore: Remove unused import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants