Skip to content

fix: Improve node ID check robustness & WebdriverIO test CI stability #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenHenning merged 8 commits into from
Sep 25, 2025
Merged

fix: Improve node ID check robustness & WebdriverIO test CI stability #745

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
600dbef
fix: Improve node ID check robustness
BenHenning Sep 25, 2025
cfb37da
fix: Lint issue.
BenHenning Sep 25, 2025
8a644d9
feat: Support CI-specific WDIO runs.
BenHenning Sep 25, 2025
9aece47
feat: Use extended Mocha timeouts in CI.
BenHenning Sep 25, 2025
2cc6ffe
Fix: Fix package.json formatting issue.
BenHenning Sep 25, 2025
5556dcd
feat: Attempt to improve timeouts.
BenHenning Sep 25, 2025
ae92cf5
feat: Attempt to slow down OS X tests.
BenHenning Sep 25, 2025
aee77d9
Revert "feat: Attempt to slow down OS X tests."
BenHenning Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/webdriverio/test/block_comment_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
await keyRight(this.browser);
await sendKeyAndWait(this.browser, Key.Enter);
const focusedNodeId = await getCurrentFocusNodeId(this.browser);
chai.assert.equal(focusedNodeId, 'blockly-2s_comment_textarea_');
chai.assert.isDefined(focusedNodeId);
chai.assert.match(focusedNodeId, /blockly\-\w+_comment_textarea_/);

Check failure on line 40 in test/webdriverio/test/block_comment_test.ts

View workflow job for this annotation

GitHub Actions / Eslint check 

Unnecessary escape character: \-
});

test('Escape from a focused comment focuses its bubble', async function () {
Expand Down
Loading