refactor: Remove INavigable in favor of IFocusableNode. (#9037)

* refactor: Remove INavigable in favor of IFocusableNode.

* chore: Fix JSDoc.

* chore: Address review feedback.

Author: gonfunko

core/block_svg.ts

@@ -47,7 +47,6 @@ import type {IDragStrategy, IDraggable} from './interfaces/i_draggable.js';
 import type {IFocusableNode} from './interfaces/i_focusable_node.js';
 import type {IFocusableTree} from './interfaces/i_focusable_tree.js';
 import {IIcon} from './interfaces/i_icon.js';
-import type {INavigable} from './interfaces/i_navigable.js';
 import * as internalConstants from './internal_constants.js';
 import {Msg} from './msg.js';
 import * as renderManagement from './render_management.js';
@@ -77,8 +76,7 @@ export class BlockSvg
     ICopyable<BlockCopyData>,
     IDraggable,
     IDeletable,
-    IFocusableNode,
-    INavigable<BlockSvg>
+    IFocusableNode
 {
   /**
    * Constant for identifying rows that are to be rendered inline.
@@ -1796,16 +1794,4 @@ export class BlockSvg
   canBeFocused(): boolean {
     return true;
   }
-
-  /**
-   * Returns this block's class.
-   *
-   * Used by keyboard navigation to look up the rules for navigating from this
-   * block.
-   *
-   * @returns This block's class.
-   */
-  getClass() {
-    return BlockSvg;
-  }
 }

core/blockly.ts

@@ -171,7 +171,7 @@ import {
 import {IVariableMap} from './interfaces/i_variable_map.js';
 import {IVariableModel, IVariableState} from './interfaces/i_variable_model.js';
 import * as internalConstants from './internal_constants.js';
-import {CursorOptions, LineCursor} from './keyboard_nav/line_cursor.js';
+import {LineCursor} from './keyboard_nav/line_cursor.js';
 import {Marker} from './keyboard_nav/marker.js';
 import type {LayerManager} from './layer_manager.js';
 import * as layers from './layers.js';
@@ -429,7 +429,7 @@ Names.prototype.populateProcedures = function (
 };
 // clang-format on
 
-export * from './interfaces/i_navigable.js';
+export * from './flyout_navigator.js';
 export * from './interfaces/i_navigation_policy.js';
 export * from './keyboard_nav/block_navigation_policy.js';
 export * from './keyboard_nav/connection_navigation_policy.js';
@@ -457,7 +457,6 @@ export {
   ContextMenuItems,
   ContextMenuRegistry,
   Css,
-  CursorOptions,
   DeleteArea,
   DragTarget,
   Events,

core/field.ts

@@ -26,7 +26,6 @@ import type {Input} from './inputs/input.js';
 import type {IFocusableNode} from './interfaces/i_focusable_node.js';
 import type {IFocusableTree} from './interfaces/i_focusable_tree.js';
 import type {IKeyboardAccessible} from './interfaces/i_keyboard_accessible.js';
-import type {INavigable} from './interfaces/i_navigable.js';
 import type {IRegistrable} from './interfaces/i_registrable.js';
 import {ISerializable} from './interfaces/i_serializable.js';
 import type {ConstantProvider} from './renderers/common/constants.js';
@@ -68,12 +67,7 @@ export type FieldValidator<T = any> = (newValue: T) => T | null | undefined;
  * @typeParam T - The value stored on the field.
  */
 export abstract class Field<T = any>
-  implements
-    IKeyboardAccessible,
-    IRegistrable,
-    ISerializable,
-    IFocusableNode,
-    INavigable<Field<T>>
+  implements IKeyboardAccessible, IRegistrable, ISerializable, IFocusableNode
 {
   /**
    * To overwrite the default value which is set in **Field**, directly update
@@ -1410,16 +1404,6 @@ export abstract class Field<T = any>
       `Attempted to instantiate a field from the registry that hasn't defined a 'fromJson' method.`,
     );
   }
-
-  /**
-   * Returns this field's class.
-   *
-   * Used by keyboard navigation to look up the rules for navigating from this
-   * field. Must be implemented by subclasses.
-   *
-   * @returns This field's class.
-   */
-  abstract getClass(): new (...args: any) => Field<T>;
 }
 
 /**

core/field_checkbox.ts

@@ -228,18 +228,6 @@ export class FieldCheckbox extends Field<CheckboxBool> {
     // 'override' the static fromJson method.
     return new this(options.checked, undefined, options);
   }
-
-  /**
-   * Returns this field's class.
-   *
-   * Used by keyboard navigation to look up the rules for navigating from this
-   * field.
-   *
-   * @returns This field's class.
-   */
-  getClass() {
-    return FieldCheckbox;
-  }
 }
 
 fieldRegistry.register('field_checkbox', FieldCheckbox);

core/field_dropdown.ts

@@ -796,18 +796,6 @@ export class FieldDropdown extends Field<string> {
       throw TypeError('Found invalid FieldDropdown options.');
     }
   }
-
-  /**
-   * Returns this field's class.
-   *
-   * Used by keyboard navigation to look up the rules for navigating from this
-   * field.
-   *
-   * @returns This field's class.
-   */
-  getClass() {
-    return FieldDropdown;
-  }
 }
 
 /**

core/field_image.ts

@@ -272,18 +272,6 @@ export class FieldImage extends Field<string> {
       options,
     );
   }
-
-  /**
-   * Returns this field's class.
-   *
-   * Used by keyboard navigation to look up the rules for navigating from this
-   * field.
-   *
-   * @returns This field's class.
-   */
-  getClass() {
-    return FieldImage;
-  }
 }
 
 fieldRegistry.register('field_image', FieldImage);

core/field_label.ts

@@ -126,18 +126,6 @@ export class FieldLabel extends Field<string> {
     // the static fromJson method.
     return new this(text, undefined, options);
   }
-
-  /**
-   * Returns this field's class.
-   *
-   * Used by keyboard navigation to look up the rules for navigating from this
-   * field.
-   *
-   * @returns This field's class.
-   */
-  getClass() {
-    return FieldLabel;
-  }
 }
 
 fieldRegistry.register('field_label', FieldLabel);

core/field_number.ts

@@ -341,18 +341,6 @@ export class FieldNumber extends FieldInput<number> {
       options,
     );
   }
-
-  /**
-   * Returns this field's class.
-   *
-   * Used by keyboard navigation to look up the rules for navigating from this
-   * field.
-   *
-   * @returns This field's class.
-   */
-  getClass() {
-    return FieldNumber;
-  }
 }
 
 fieldRegistry.register('field_number', FieldNumber);

core/field_textinput.ts

@@ -89,18 +89,6 @@ export class FieldTextInput extends FieldInput<string> {
     // override the static fromJson method.
     return new this(text, undefined, options);
   }
-
-  /**
-   * Returns this field's class.
-   *
-   * Used by keyboard navigation to look up the rules for navigating from this
-   * field.
-   *
-   * @returns This field's class.
-   */
-  getClass() {
-    return FieldTextInput;
-  }
 }
 
 fieldRegistry.register('field_input', FieldTextInput);

core/flyout_base.ts

@@ -20,6 +20,7 @@ import {EventType} from './events/type.js';
 import * as eventUtils from './events/utils.js';
 import {FlyoutItem} from './flyout_item.js';
 import {FlyoutMetricsManager} from './flyout_metrics_manager.js';
+import {FlyoutNavigator} from './flyout_navigator.js';
 import {FlyoutSeparator, SeparatorAxis} from './flyout_separator.js';
 import {getFocusManager} from './focus_manager.js';
 import {IAutoHideable} from './interfaces/i_autohideable.js';
@@ -243,6 +244,7 @@ export abstract class Flyout
     this.workspace_.internalIsFlyout = true;
     // Keep the workspace visibility consistent with the flyout's visibility.
     this.workspace_.setVisible(this.visible);
+    this.workspace_.setNavigator(new FlyoutNavigator(this));
 
     /**
      * The unique id for this component that is used to register with the