-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
issue: bugDescribes why the code or behaviour is wrongDescribes why the code or behaviour is wrongissue: triageIssues awaiting triage by a Blockly team memberIssues awaiting triage by a Blockly team member
Description
Check for duplicates
- I have searched for similar issues before opening a new one.
Description
Dragging is broken in the add-screen-reader-support-experimental branch, for geras and thrasos renderers.
I've done a bisect and it goes all the way back to the start of this branch in #9280 but haven't continued investigating past that.
This is inconvenient now because there are new tests in the kbe branch that test moving (which is broken since it's dragging) in geras and thrasos renderers. Those tests always failing will make verifying new changes to this branch difficult.
Reproduction steps
git checkout add-screen-reader-support-experimentalnpm start- change the renderer settings to use geras
- Try to drag a block and connect it to another one
Stack trace
Uncaught TypeError: Cannot read properties of undefined (reading 'getNextBlock')
at BlockSvg.collectSiblingBlocks (block_svg.ts:271:41)
at WorkspaceSvg.recomputeAriaTreeItemDetailsRecursively (workspace_svg.ts:2969:31)
at workspace_svg.ts:2952:12
at Array.forEach (<anonymous>)
at WorkspaceSvg.recomputeAriaTree (workspace_svg.ts:2951:30)
at BlockSvg.setParent (block_svg.ts:413:20)
at RenderedConnection.disconnectInternal (connection.ts:305:53)
at RenderedConnection.disconnectInternal (rendered_connection.ts:504:11)
at RenderedConnection.disconnect (connection.ts:270:10)
at BlockSvg.unplugFromRow (block.ts:426:29)Screenshots
No response
Browsers
No response
Metadata
Metadata
Assignees
Labels
issue: bugDescribes why the code or behaviour is wrongDescribes why the code or behaviour is wrongissue: triageIssues awaiting triage by a Blockly team memberIssues awaiting triage by a Blockly team member
Type
Projects
Status
Done